[devel] [PATCH 0/1] Review Request for clm: replace immadm command with admin op call in clm test [#2654]

[Zoran M. <zor...@er...>]

Summary: clm: replace immadm command with admin op call in clm test [#2654]
Review request for Ticket(s): 2654
Peer Reviewer(s): Gary
Pull request to: Zoran
Affected branch(es): develop
Development branch: ticket-2654
Base revision: ee7cb901b8eb023502e3c21180afb78dd15c328b
Personal repository: git://git.code.sf.net/u/zmilinkovic/review

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n

NOTE: Patch(es) contain lines longer than 80 characers

Comments (indicate scope for each "y" above):
---------------------------------------------

revision 56ee9e7557c84416367e0510c0dc3023f29be9ad
Author:	Zoran Milinkovic <zor...@er...>
Date:	Wed, 25 Oct 2017 17:14:43 +0200

clm: replace immadm command with admin op call in clm test [#2654]

Due to long execution of immadm in a separated thread and possible timeout in poll, the executing immadm command for locking, unlocking and shutting down nodes is replaced with calling IMM admin operation function.



Complete diffstat:
------------------
 src/clm/apitest/clmtest.c               | 92 +++++++++++++++++++++++++++++++++
 src/clm/apitest/clmtest.h               |  4 ++
 src/clm/apitest/tet_ClmLongRdn.c        | 35 +++----------
 src/clm/apitest/tet_saClmClusterTrack.c | 38 ++------------
 4 files changed, 106 insertions(+), 63 deletions(-)


Testing Commands:
-----------------
clmtest


Testing, Expected Results:
--------------------------
All tests must pass


Conditions of Submission:
-------------------------
Ack from Gary


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.