[devel] [PATCH 0/1] Review Request for clm: add new admin operations [#2649]

[Zoran M. <zor...@er...>]

Summary: clm: add new admin operations [#2649]
Review request for Ticket(s): 2649
Peer Reviewer(s): Hans, Anders, Ravi
Pull request to: Zoran
Affected branch(es): develop
Development branch: ticket-2649
Base revision: 308272ff1ce831e6295b744f7f903334ad485052
Personal repository: git://git.code.sf.net/u/zmilinkovic/review

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n

NOTE: Patch(es) contain lines longer than 80 characers

Comments (indicate scope for each "y" above):
---------------------------------------------

revision 139140322c7fb0674763fcc3ab802e9aeb608794
Author:	Zoran Milinkovic <zor...@er...>
Date:	Mon, 23 Oct 2017 16:29:44 +0200

clm: add new admin operations [#2649]

Add two new admin operations to CLM.
1. Node reboot will use the same openation id as cluster reboot, but the DN will contain CLM node

   Example for rebooting SC2:
     immadm -o 4 safNode=SC-2,safCluster=myClmCluster

2. Execute action on remote nodei(s) with operation id 5.
   Action is a script stored in /usr/lib/opensaf/clm-scripts directory started with prefix "osafclm_"
   The action name needs to be provided by saClmAction parameter, which is type of SaStringT.
   If the targeted DN is CLM node, the action will be done on the node.
   If the targeted DN is CLM cluster DN, the action will be done on all nodes in the cluster.

   Example for executing clm-scripts/osafclm_stop script on SC-2:
     immadm -o 5 -p saClmAction:SA_STRING_T:stop safNode=SC-2,safCluster=myClmCluster

   Example for executing clm-scripts/osafclm_stop script on all nodes:
     immadm -o 5 -p saClmAction:SA_STRING_T:stop safCluster=myClmCluster



Added Files:
------------
 scripts/clm-scripts/osafclm_stop


Complete diffstat:
------------------
 Makefile.am                      |   8 ++-
 opensaf.spec.in                  |   2 +
 scripts/clm-scripts/osafclm_stop |   4 ++
 src/ais/include/saClm.h          |   3 +-
 src/clm/Makefile.am              |   3 ++
 src/clm/clmd/clms.h              |   2 +
 src/clm/clmd/clms_imm.c          | 104 ++++++++++++++++++++++++++++++++++++---
 src/clm/clmd/clms_mds.c          |  15 +++++-
 src/clm/clmd/clms_util.c         |  33 +++++++++++++
 src/clm/clmnd/main.c             |  80 ++++++++++++++++++++++++++++++
 src/clm/common/clmsv_msg.h       |   8 +++
 11 files changed, 253 insertions(+), 9 deletions(-)


Testing Commands:
-----------------
Test examples from the description


Testing, Expected Results:
--------------------------
Examples from the description should work


Conditions of Submission:
-------------------------
Ack from Hans, Anders and Ravi


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.