[devel] [PATCH 0/1] Review Request for imm: remove disconnected appliers [#2579]

[Zoran M. <zor...@er...>]

Summary: imm: remove disconnected appliers [#2579]
Review request for Ticket(s): 2579
Peer Reviewer(s): Hung
Pull request to: Zoran
Affected branch(es): develop
Development branch: ticket-2579
Base revision: 10a83558372bbeae8b2d09e0fefd55cbc11dbd5d
Personal repository: git://git.code.sf.net/u/zmilinkovic/review

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n

NOTE: Patch(es) contain lines longer than 80 characers

Comments (indicate scope for each "y" above):
---------------------------------------------

revision b843838c0f947dedc53410729d4fb9c600501000
Author:	Zoran Milinkovic <zor...@er...>
Date:	Mon, 11 Sep 2017 17:46:23 +0200

imm: remove disconnected appliers [#2579]

When an applier is disconnected, it will be removed from the system after time period set in minApplierTimeout attribute in IMM object.
If the time is set to 0, it will work as it works today, and it will never be removed from the system.

The time set in minApplierTimeout attribute guarantees that the applier will be "alive" for at least the time set in the attribute.
When this period expires, with the next clean the basement call, the applier will be removed.

The time set in minApplierTimeout attribute is in seconds.

To enable this feature, protocol51710 must be enabled and minApplierTimeout attribute value must be great than 0.



Added Files:
------------
 samples/immsv/OpensafImm_Upgrade_5.17.10.xml


Complete diffstat:
------------------
 samples/immsv/OpensafImm_Upgrade_5.17.10.xml | 120 +++++++++++++++++
 src/imm/common/immsv_api.h                   |   2 +
 src/imm/common/immsv_evt.c                   | 118 ++++++++++++++++
 src/imm/common/immsv_evt.h                   |  14 ++
 src/imm/immd/immd_evt.c                      |  69 ++++++++++
 src/imm/immloadd/imm_loader.cc               |  12 +-
 src/imm/immnd/ImmModel.cc                    | 193 ++++++++++++++++++++++++++-
 src/imm/immnd/ImmModel.h                     |   6 +-
 src/imm/immnd/immnd_evt.c                    |  43 ++++++
 src/imm/immnd/immnd_init.h                   |   5 +-
 src/imm/immnd/immnd_proc.c                   |  41 +++++-
 11 files changed, 613 insertions(+), 10 deletions(-)


Testing Commands:
-----------------


Testing, Expected Results:
--------------------------
Disconnected appliers should be removed from the system after time period set in minApplierTimeout


Conditions of Submission:
-------------------------
Ack from Hung


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.