[devel] [PATCH 0 of 1] Review Request for amfd: choose CLM unlocked spare controller for standby role in failover situation[#2387]

[<pra...@or...>]

Summary: amfd: choose CLM unlocked spare controller for standby role in failover situation[#2387]
Review request for Trac Ticket(s): #2387 
Peer Reviewer(s): AMF devs 
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): ALL 
Development branch: <<IF ANY GIVE THE REPO URL>>

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 9d28b2e0bba4e479bc65c0df6d55d6cc3f71ecd4
Author:	Praveen Malviya <pra...@or...>
Date:	Tue, 21 Mar 2017 15:06:48 +0530

	amfd: choose CLM unlocked spare controller for standby role in failover
	situation[#2387]

	When spare controllers are configured in cluster, AMF is chosing CLM locked
	controller for fresh standby controller during failover situation. Currently
	fresh standby assignment on CLM locked controller in failover situation
	fails because of issue in SMF #1791. Even if SMF issue is fixed, AMF may
	choose a CLM locked controller for fresh assignment. This will prohibit a
	user to use si-swap operation for controller swap.

	If available, AMF must choose CLM unlocked spare controller for fresh
	standby assignments.


Complete diffstat:
------------------
 src/amf/amfd/clm.cc       |   2 ++
 src/amf/amfd/sg_2n_fsm.cc |  12 +++++++++++-
 2 files changed, 13 insertions(+), 1 deletions(-)


Testing Commands:
-----------------
Brought 5 controllers up in UML envirnment.
CLM lock of SC-3.
Stop opensaf on active controller.

Testing, Expected Results:
--------------------------
AMF does not chose CLM locked spare controller for fresh standby assignments.

Conditions of Submission:
-------------------------
Ack from reviewers.

Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.