[devel] [PATCH 0 of 1] Review Request for imm: add a precedence of validation abort error string over resource abort error string [#1554]

[Zoran M. <zor...@er...>]

Summary: imm: add a precedence of validation abort error string over resource abort error string [#1554]
Review request for Trac Ticket(s): 1554
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.7.x, default(5.0)
Development branch: default(5.0)

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 6a6dc92c4eb556fdf8dbba48b9ae6314e8d36364
Author:	Zoran Milinkovic <zor...@er...>
Date:	Mon, 26 Oct 2015 11:22:52 +0100

	imm: add a precedence of validation abort error string over resource abort
	error string [#1554]

	The patch add a precedence of validation error string over resource abort
	error string. If resource abort error string exists, it will be overwritten
	by validation abort error string. If at least one validation abort error
	string exist, new resource abort error string will not be adda.

	Since the new check of abort error strings is done in setCcbErrorString, the
	patch removes earlier code for ignoring several abort error strings.


Complete diffstat:
------------------
 osaf/services/saf/immsv/immnd/ImmModel.cc |  103 +++++++++++++++++++++++++++++++------------------------------------------------------------------------
 1 files changed, 31 insertions(+), 72 deletions(-)


Testing Commands:
-----------------


Testing, Expected Results:
--------------------------
Test next 3 test cases:
1. only one resource abort error string can be in error strings
2. one or more validation error strings from multiple OIs can be in error strings
3. validation abort overwrites resource abort


Conditions of Submission:
-------------------------
Ack from Neelakanta


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.