Menu
▾
▴
[devel] [PATCH 0 of 4] Review Request for imm: add support for replacement SaNameT with SaStringT [#643]
|
From: Zoran M. <zor...@er...> - 2015-03-10 15:49:09
|
Summary: imm: add support for replacement SaNameT with SaStringT [#643]
Review request for Trac Ticket(s): 643
Peer Reviewer(s): Neelakanta, Anders
Pull request to: Zoran
Affected branch(es): default(4.6)
Development branch: default(4.6)
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 57bcdde2358f69b5696fdd7002e3f1decd8da69d
Author: Zoran Milinkovic <zor...@er...>
Date: Tue, 10 Mar 2015 16:37:08 +0100
imm: add new API functions for replacement SaNameT with SaStringT [#643]
New functions with suffix "_o3" are added. New functions should replace
usage SaNameT with easier use of SaStringT type. SA_IMM_ATTR_DN is a new
flag that can be used only with SaStringT type, and it's meaning with
SaStringT is same as SaNameT. NO_DANGLING feature applies to attributes with
SA_IMM_ATTR_DN flag.
changeset df77a8bb3373a871032a0c702f5e28d920ae35a8
Author: Zoran Milinkovic <zor...@er...>
Date: Tue, 10 Mar 2015 16:38:39 +0100
imm: service support for replacement SaNameT with SaStringT [#643]
IMM service support for replacement SaNameT type with SaStringT.
SA_IMM_ATTR_DN is a new flag that can be used only with SaStringT type, and
it's meaning with SaStringT is same as SaNameT. The logic for NO_DANGLING
feature on attributes with SA_IMM_ATTR_DN flag is implemented in IMM
service.
changeset 5bea7db1d45bba2c9748e125ec8fde79597e4602
Author: Zoran Milinkovic <zor...@er...>
Date: Tue, 10 Mar 2015 16:39:52 +0100
immtools: support for replacement SaNameT with SaStringT in IMM tools [#643]
Support for replacement SaNameT with SaStringT is added to IMM tools.
changeset 075ad5d7da7fc5bd2d50225ef1a19145770eaada
Author: Zoran Milinkovic <zor...@er...>
Date: Tue, 10 Mar 2015 16:40:49 +0100
immtest: add tests for replacement SaNameT with SaStringT [#643]
New tests for replacement SaNameT with SaStringT are added to immoitest and
immomtest.
Added Files:
------------
osaf/libs/saf/include/saImmOi_A_2_15.h
osaf/libs/saf/include/saImmOm_A_2_15.h
osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.15.xsd
tests/immsv/implementer/test_saImmOiSaStringT.c
tests/immsv/management/test_saImmOmSaStringT.c
Complete diffstat:
------------------
opensaf.spec.in | 2 +
osaf/libs/agents/saf/imma/imma_cb.h | 3 +
osaf/libs/agents/saf/imma/imma_def.h | 2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 513 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------
osaf/libs/agents/saf/imma/imma_om_api.c | 1038 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------
osaf/libs/agents/saf/imma/imma_proc.c | 207 +++++++++++++++++++++++---------
osaf/libs/common/immsv/immsv_evt.c | 30 +++-
osaf/libs/common/immsv/include/immpbe_dump.hh | 2 +-
osaf/libs/common/immsv/include/immsv_api.h | 1 +
osaf/libs/common/immsv/include/immsv_evt.h | 3 +
osaf/libs/common/immsv/include/immsv_evt_model.h | 2 +-
osaf/libs/saf/include/Makefile.am | 4 +-
osaf/libs/saf/include/saImmOi_A_2_11.h | 2 +
osaf/libs/saf/include/saImmOi_A_2_15.h | 122 +++++++++++++++++++
osaf/libs/saf/include/saImmOm_A_2_14.h | 2 +
osaf/libs/saf/include/saImmOm_A_2_15.h | 168 ++++++++++++++++++++++++++
osaf/services/saf/immsv/immloadd/imm_loader.cc | 11 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc | 2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 371 ++++++++++++++++++++++++++++++++++++++++++++++-------------
osaf/services/saf/immsv/immnd/ImmModel.hh | 6 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 44 +++++-
osaf/services/saf/immsv/immnd/immnd_init.h | 5 +-
osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.15.xsd | 181 ++++++++++++++++++++++++++++
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 7 +-
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immfind/imm_find.c | 2 +-
osaf/tools/safimm/immlist/imm_list.c | 8 +-
tests/immsv/common/immtest.c | 4 +-
tests/immsv/implementer/Makefile.am | 1 +
tests/immsv/implementer/test_cleanup.c | 3 +
tests/immsv/implementer/test_saImmOiClassImplementerSet.c | 2 -
tests/immsv/implementer/test_saImmOiImplementerSet.c | 6 -
tests/immsv/implementer/test_saImmOiLongDn.c | 4 -
tests/immsv/implementer/test_saImmOiSaStringT.c | 1061 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/immsv/management/Makefile.am | 1 +
tests/immsv/management/test_cleanup.c | 3 +
tests/immsv/management/test_saImmOmCcbObjectCreate_2.c | 4 -
tests/immsv/management/test_saImmOmCcbObjectModify_2.c | 2 -
tests/immsv/management/test_saImmOmSaStringT.c | 592 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
41 files changed, 3822 insertions(+), 612 deletions(-)
Testing Commands:
-----------------
immomtest
immoitest
Testing, Expected Results:
--------------------------
Both immoitest and immomtest must pass all tests
Conditions of Submission:
-------------------------
Ack from Neelakanta and Anders
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
|
