Menu
▾
▴
[devel] [PATCH 0 of 2] Review Request for Imm: Return NO_RESOURCES when slave PRTA timesout and prepare arrives after the slave timeout [#1211]
|
From: <red...@or...> - 2014-11-17 14:45:00
|
Summary: Imm: Return NO_RESOURCES when slave PRTA timesout and prepare arrives after the slave timeout [#1211]
Review request for Trac Ticket(s): 1211
Peer Reviewer(s): AndersBj
Affected branch(es): 4.4.x, 4.5.x, default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset e1b9c8c261027c73acace57c6fdaad9b115337cc
Author: Neelakanta Reddy<red...@or...>
Date: Mon, 17 Nov 2014 20:16:39 +0530
Imm: Return NO_RESOURCES when slave PRTA timesout and prepare arrives after
the slave timeout [#1211]
For PRTA updates
1.By the time primary PBE sends prepare towards slave the slave PBE has been
timed out. Primary PBE got OK response on prepare towards slave PBE. Because
of this the PRTA update is successful in primary PBE and unsuccessful in IMM
and PBE slave.
Nov 13 11:38:25 SLES-64BIT-SLOT1 osafimmpbed: IN Slave PBE replied with OK
on attempt to start prepare of ccb:100000187/4294967687 Nov 13 11:38:25
SLES-64BIT-SLOT1 osafimmpbed: IN Starting distributed PBE commit for PRTA
update Ccb:100000188/4294967688 Nov 13 11:38:25 SLES-64BIT-SLOT1
osafimmnd[3145]: ER PBE PRTAttrs Update continuation missing! invoc:391
Nov 13 11:38:14 SLES-64BIT-SLOT2 osafimmpbed: IN PBE slave waiting for
prepare from primary on PRTA update ccb:100000187 Nov 13 11:38:14 SLES-
64BIT-SLOT2 osafimmpbed: NO Slave PBE time-out in waiting on prepare for
PRTA update ccb:100000187 dn:safNode=PL-3,safCluster=myClmCluster
Nov 13 11:38:25 SLES-64BIT-SLOT2 osafimmpbed: IN ccb-prepare received at PBE
slave ccbId:100000187/4294967687 numOps:1
In Modify callback ccbUtilCcbData is not cleared, and when ccb-prepare is
received at slave the s2PbeBCcbToCompleteAtB is set to the ccbid and this
value is not cleared. Because of this CCB slave goes on rejecting the
further PRTA/CCB operations.
Nov 13 11:38:25 SLES-64BIT-SLOT2 osafimmpbed: NO Prepare
ccb:100000188/4294967688 received at Pbe slave when Prior Ccb 4294967687
still processing
Nov 13 12:21:47 SLES-64BIT-SLOT2 osafimmpbed: NO Prepare
ccb:10000046b/4294968427 received at Pbe slave when Prior Ccb 4294967687
still processing
solution : If there a timeout in waiting on prepare for PRTA then delete the
ccbutildata, this has been cleared in create callback but not in modify
callback. In pbe2_ok_to_prepare_ccb if ccbutil data is not found the return
NO_RESOURCE.
changeset a54fabd9a63315d79deb2c99824bae50312e26c7
Author: Neelakanta Reddy<red...@or...>
Date: Mon, 17 Nov 2014 20:16:55 +0530
Imm: Wait for reply from other PBE when ERR_NO_RESOURCES is returned [#1211]
lave PBE sends UPDATE_RSP to IMM and the continuation is removed and when
the response comes again for primary PBE the following error is displayed:
Nov 13 11:38:25 SLES-64BIT-SLOT2 osafimmnd[2491]: ER PBE PRTAttrs Update
continuation missing! invoc:391
Nov 13 11:38:25 SLES-64BIT-SLOT2 osafimmnd[2491]: ER PBE PRTAttrs Update
continuation missing! invoc:391
solution: The RSP from
pbePrtObjCreateContinuation/pbePrtAttrUpdateContinuation is received twice
when 2PBE is configured, if error SA_AIS_ERR_NO_RESOURCES is returned then
Wait for reply from other PBE
Complete diffstat:
------------------
osaf/services/saf/immsv/immnd/ImmModel.cc | 4 ++--
osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 45 ++++++++++++++++++++-------------------------
2 files changed, 22 insertions(+), 27 deletions(-)
Testing Commands:
-----------------
Delay PRTA-update for 5 seconds before sending prepare towards slave. By this time the slave PBE will timeout
Testing, Expected Results:
--------------------------
If slave PBE receives prepare after slave PBE timeout in callback NO_RESOURCES is returned.
slave PBE must not reject the next CCBs/PRTA operations, if slave PBE receives prepare after slave PBE timeout
"ER PBE PRTAttrs Update continuation missing!" should not be returned.
Conditions of Submission:
-------------------------
Ack from AndersBj
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
|
