[devel] [PATCH 0 of 2] Review Request for IMM: fix floating point values for printing, dumping and loading from PBE [#53]

[Zoran M. <zor...@er...>]

Summary: IMM: fix floating point values for printing, dumping and loading from PBE [#53]
Review request for Trac Ticket(s): 53
Peer Reviewer(s): Anders, Neelakanta
Pull request to: Zoran
Affected branch(es): default(4.5)
Development branch: default(4.5)

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 74f2f1582630a69c25e9b6b7927889ef0be95aee
Author:	Zoran Milinkovic <zor...@er...>
Date:	Tue, 15 Apr 2014 16:10:24 +0200

	IMMTOOLS: fix printing and dumping for float and double values [#53]

	Set a correct floating point precision for printed and dumped float and
	double values, so that the floating point precision is not lost when the
	floating point value in a string representation is converted back to float
	and double value.

changeset 8ac2aecdf16b1542d535caabd1cee19edfc75276
Author:	Zoran Milinkovic <zor...@er...>
Date:	Tue, 15 Apr 2014 16:20:03 +0200

	IMM: fix loading double values from PBE in immload [#53]

	When PBE is being loaded, sqlite3_column_text function is used for fetching
	double values. The function returns a string representation of double value
	in 15 bytes, which is not enough to preserve full floating point
	presicision.


Complete diffstat:
------------------
 osaf/libs/common/immsv/immpbe_dump.cc            |   2 ++
 osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |  25 +++++++++++++++++++------
 osaf/tools/safimm/immlist/imm_list.c             |   8 ++++----
 3 files changed, 25 insertions(+), 10 deletions(-)


Testing Commands:
-----------------
immdump test.xml
immlist <DN>


Testing, Expected Results:
--------------------------
immdump must export big float and double values in a scientific format (including exponent).
immlist must print big float and double values in a scientific format.
immload must import big float and double values from XML file dumped by immdump. The precision should not be lost.
immload should not lose floating point precision after cluster reboot when PBE is enabled.


Conditions of Submission:
-------------------------
Ack from Neelakanta and Anders


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.