[devel] [PATCH 0 of 2] Review Request for IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

[Zoran M. <zor...@er...>]

Summary: IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]
Review request for Trac Ticket(s): 459
Peer Reviewer(s): Anders, Neelakanta
Pull request to: Zoran
Affected branch(es): default(4.5)
Development branch: default(4.5)

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset a866790f3345c3f99c57d7cb9aa9579a1d5c34ad
Author:	Zoran Milinkovic <zor...@er...>
Date:	Wed, 02 Apr 2014 15:22:02 +0200

	IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

	When an implementer is detached from an object/class, CCB operations return
	ERR_NOT_EXIST error code. The patch should give more information regarding
	the error code in the error string.

changeset b02f4b505de84c6fb338880292835ba45074ce6a
Author:	Zoran Milinkovic <zor...@er...>
Date:	Wed, 02 Apr 2014 15:24:46 +0200

	IMMTOOLS: write error strings for ERR_NOT_EXIST error code in immcfg [#459]


Complete diffstat:
------------------
 osaf/services/saf/immsv/immnd/ImmModel.cc |  60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 osaf/services/saf/immsv/immnd/ImmModel.hh |   5 +++++
 osaf/services/saf/immsv/immnd/immnd_evt.c |  27 ++++++++++++++++++++++++---
 osaf/tools/safimm/immcfg/imm_cfg.c        |  69 ++++++++++++++++++++++++++++++++++++---------------------------------
 4 files changed, 125 insertions(+), 36 deletions(-)


Testing Commands:
-----------------
immcfg -a attr=123 id=1
immcfg -d id=1
immcfg -c TestClass id=2


Testing, Expected Results:
--------------------------
Create an object of a TestClass ("immcfg -c TestClass id=1").
Attach an implementer to the class using immapplier ("immapplier -a TestImpl TestClass").
Exit from immapplier (Ctrl+C).
1. Modify id=1 ("immcfg -a attr=123 id=1"), and the error string (ERR_NOT_EXIST) should be written to the output
2. Delete id=1 ("immcfg -d id=1"), and the error string (ERR_NOT_EXIST) should be written to the output
3. Create a new object of class TestClass ("immcfg -c TestClass id=2"), and the error string (ERR_NOT_EXIST) should be written to the output.


Conditions of Submission:
-------------------------
Ack from Anders and Neelakanta


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.