Menu
▾
▴
[devel] [PATCH 0 of 1] Review Request for IMMTOOLS: fix the schema name for immxml tools to comply with the latest schema known by the release [#796]
|
From: Zoran M. <zor...@er...> - 2014-03-06 13:47:54
|
Summary: IMMTOOLS: fix the schema name for immxml tools to comply with the latest schema known by the release [#796]
Review request for Trac Ticket(s): 796
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.4.x, default(4.5)
Development branch: default(4.5)
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset e392e08b28e60d6ea541a52b50238039cec9f770
Author: Zoran Milinkovic <zor...@er...>
Date: Thu, 06 Mar 2014 14:39:12 +0100
IMMTOOLS: fix the schema name for immxml tools to comply with the latest
schema known by the release [#796]
Complete diffstat:
------------------
osaf/services/infrastructure/fm/config/fm_objects.xml | 2 +-
osaf/services/infrastructure/fm/config/fm_sc_template.xml | 2 +-
osaf/services/infrastructure/rde/config/rde_objects.xml | 2 +-
osaf/services/infrastructure/rde/config/rde_sc_template.xml | 2 +-
osaf/services/saf/amf/config/amf_classes.xml | 2 +-
osaf/services/saf/amf/config/amf_objects.xml | 2 +-
osaf/services/saf/amf/config/amfwdog_objects.xml | 2 +-
osaf/services/saf/amf/config/amfwdog_pl_template.xml | 2 +-
osaf/services/saf/amf/config/amfwdog_sc_template.xml | 2 +-
osaf/services/saf/amf/config/common_pl_template.xml | 2 +-
osaf/services/saf/amf/config/common_sc_template.xml | 2 +-
osaf/services/saf/clmsv/config/clmsv_classes.xml | 2 +-
osaf/services/saf/clmsv/config/clmsv_objects.xml | 2 +-
osaf/services/saf/clmsv/config/clmsv_pl_template.xml | 2 +-
osaf/services/saf/clmsv/config/clmsv_plm_pl_template.xml | 2 +-
osaf/services/saf/clmsv/config/clmsv_plm_sc_template.xml | 2 +-
osaf/services/saf/clmsv/config/clmsv_sc_template.xml | 2 +-
osaf/services/saf/cpsv/config/cpsv_classes.xml | 2 +-
osaf/services/saf/cpsv/config/cpsv_objects.xml | 2 +-
osaf/services/saf/cpsv/config/cpsv_pl_template.xml | 2 +-
osaf/services/saf/cpsv/config/cpsv_sc_template.xml | 2 +-
osaf/services/saf/edsv/config/edsv_classes.xml | 2 +-
osaf/services/saf/edsv/config/edsv_objects.xml | 2 +-
osaf/services/saf/edsv/config/edsv_sc_template.xml | 2 +-
osaf/services/saf/glsv/config/glsv_classes.xml | 2 +-
osaf/services/saf/glsv/config/glsv_objects.xml | 2 +-
osaf/services/saf/glsv/config/glsv_pl_template.xml | 2 +-
osaf/services/saf/glsv/config/glsv_sc_template.xml | 2 +-
osaf/services/saf/immsv/config/imm.xml.sample | 2 +-
osaf/services/saf/immsv/config/imm_copyright.xml | 2 +-
osaf/services/saf/immsv/config/immsv_classes.xml | 2 +-
osaf/services/saf/immsv/config/immsv_objects.xml | 2 +-
osaf/services/saf/immsv/config/immsv_pl_template.xml | 2 +-
osaf/services/saf/immsv/config/immsv_sc_template.xml | 2 +-
osaf/services/saf/logsv/config/logsv_classes.xml | 2 +-
osaf/services/saf/logsv/config/logsv_objects.xml | 2 +-
osaf/services/saf/logsv/config/logsv_sc_template.xml | 2 +-
osaf/services/saf/mqsv/config/mqsv_classes.xml | 2 +-
osaf/services/saf/mqsv/config/mqsv_objects.xml | 2 +-
osaf/services/saf/mqsv/config/mqsv_pl_template.xml | 2 +-
osaf/services/saf/mqsv/config/mqsv_sc_template.xml | 2 +-
osaf/services/saf/ntfsv/config/ntfsv_objects.xml | 2 +-
osaf/services/saf/ntfsv/config/ntfsv_sc_template.xml | 2 +-
osaf/services/saf/plmsv/config/plmsv_classes.xml | 2 +-
osaf/services/saf/plmsv/config/plmsv_objects.xml | 2 +-
osaf/services/saf/plmsv/config/plmsv_objects.xml.atca | 2 +-
osaf/services/saf/plmsv/config/plmsv_objects.xml.hp | 2 +-
osaf/services/saf/plmsv/config/plmsv_objects.xml.pc | 2 +-
osaf/services/saf/plmsv/config/plmsv_pl_template.xml | 2 +-
osaf/services/saf/plmsv/config/plmsv_sc_template.xml | 2 +-
osaf/services/saf/smfsv/config/smfsv_classes.xml | 2 +-
osaf/services/saf/smfsv/config/smfsv_objects.xml | 2 +-
osaf/services/saf/smfsv/config/smfsv_pl_template.xml | 2 +-
osaf/services/saf/smfsv/config/smfsv_sc_template.xml | 2 +-
osaf/tools/safimm/immxml/baseimm.py | 2 +-
osaf/tools/safimm/immxml/immxml-nodegen | 2 +-
56 files changed, 56 insertions(+), 56 deletions(-)
Testing Commands:
-----------------
Testing, Expected Results:
--------------------------
Check that IMMXML tools generate IMM xml file with the correct schema name.
Conditions of Submission:
-------------------------
Ack from Neelakanta
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
|
