Menu
▾
▴
[devel] [PATCH 0 of 1] Review Request for IMMTEST: fix IMM tests if 2PBE is enabled [#624]
|
From: Zoran M. <zor...@er...> - 2014-01-21 12:13:52
|
Summary: IMMTEST: fix IMM tests if 2PBE is enabled [#624]
Review request for Trac Ticket(s): 624
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.4.x, default(4.5)
Development branch: default(4.5)
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 967aa93f50e892640fa2dc81794058f75e33a7f3
Author: Zoran Milinkovic <zor...@er...>
Date: Tue, 21 Jan 2014 13:09:20 +0100
IMMTEST: fix IMM tests if 2PBE is enabled [#624]
Complete diffstat:
------------------
tests/immsv/common/immtest.c | 5 +++++
tests/immsv/common/immtest.h | 1 +
tests/immsv/implementer/test_SaImmOiAdminOperation.c | 24 ------------------------
tests/immsv/implementer/test_SaImmOiCcb.c | 24 +++++++++---------------
tests/immsv/implementer/test_cleanup.c | 32 ++++++++++++++++++++++++--------
tests/immsv/implementer/test_saImmOiAugmentCcbInitialize.c | 30 ------------------------------
tests/immsv/implementer/test_saImmOiClassImplementerRelease.c | 6 ------
tests/immsv/implementer/test_saImmOiClassImplementerSet.c | 8 --------
tests/immsv/implementer/test_saImmOiObjectImplementerRelease.c | 8 --------
tests/immsv/implementer/test_saImmOiObjectImplementerSet.c | 10 ----------
tests/immsv/implementer/test_saImmOiRtObjectCreate_2.c | 28 +++++++++++++---------------
tests/immsv/implementer/test_saImmOiRtObjectDelete.c | 22 ++++++++--------------
tests/immsv/implementer/test_saImmOiRtObjectUpdate_2.c | 22 +++++++---------------
tests/immsv/management/test_cleanup.c | 20 ++++++++++++++++++--
tests/immsv/management/test_saImmOmAdminOperationContinue.c | 12 ++++--------
tests/immsv/management/test_saImmOmAdminOwnerClear.c | 18 +++++++-----------
tests/immsv/management/test_saImmOmAdminOwnerFinalize.c | 3 +--
tests/immsv/management/test_saImmOmAdminOwnerRelease.c | 23 +++++++++--------------
tests/immsv/management/test_saImmOmAdminOwnerSet.c | 32 +++++++++++++-------------------
tests/immsv/management/test_saImmOmCcbApply.c | 16 +++++-----------
tests/immsv/management/test_saImmOmCcbFinalize.c | 6 ++----
tests/immsv/management/test_saImmOmCcbObjectCreate_2.c | 34 ++++------------------------------
tests/immsv/management/test_saImmOmCcbObjectDelete.c | 35 ++++++++++++-----------------------
tests/immsv/management/test_saImmOmCcbObjectModify_2.c | 89 ++++++++++++++++++++++++++++++-----------------------------------------------------------
tests/immsv/management/test_saImmOmThreadInterference.c | 2 --
25 files changed, 172 insertions(+), 338 deletions(-)
Testing Commands:
-----------------
immomtest
immoitest
Testing, Expected Results:
--------------------------
immomtest and immoitest must pass all tests while OpenSAF running without PBE, with PBE and with 2PBE.
Conditions of Submission:
-------------------------
Ack from Neelakanta
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
|
