Menu
▾
▴
[devel] [PATCH 0 of 3] Review Request for IMM: Add support for NO_DANGLING flag [#49]
|
From: Zoran M. <zor...@er...> - 2013-12-15 15:51:26
|
Summary: IMM: Add support for NO_DANGLING flag [#49]
Review request for Trac Ticket(s): 49
Peer Reviewer(s): Neel, Anders
Pull request to: Zoran
Affected branch(es): default(4.4)
Development branch: default(4.4)
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 5581ca82a63f307e4a7e6427fd1d898a9505ea4a
Author: Zoran Milinkovic <zor...@er...>
Date: Sun, 15 Dec 2013 16:42:12 +0100
IMM: Add support for NO_DANGLING flag to API [#49]
changeset d0d8baa7648c017838535aad044df58e3047afe2
Author: Zoran Milinkovic <zor...@er...>
Date: Sun, 15 Dec 2013 16:42:41 +0100
IMM: Add support for NO_DANGLING flag to the service [#49]
changeset 073674c99718039ad86e50e499f1415bc365dfed
Author: Zoran Milinkovic <zor...@er...>
Date: Sun, 15 Dec 2013 16:43:09 +0100
IMMTOOLS: Add support for NO_DANGLING flag to tools [#49]
Added Files:
------------
osaf/libs/saf/include/saImmOm_A_2_13.h
osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.13.xsd
Complete diffstat:
------------------
opensaf.spec.in | 1 +
osaf/libs/agents/saf/imma/imma_cb.h | 1 +
osaf/libs/agents/saf/imma/imma_def.h | 2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 12 +-
osaf/libs/agents/saf/imma/imma_om_api.c | 58 ++++++-
osaf/libs/common/immsv/include/immpbe_dump.hh | 2 +-
osaf/libs/common/immsv/include/immsv_api.h | 9 +
osaf/libs/saf/include/Makefile.am | 3 +-
osaf/libs/saf/include/saImmOm_A_2_12.h | 2 +
osaf/libs/saf/include/saImmOm_A_2_13.h | 60 ++++++++
osaf/libs/saf/libSaImm/Makefile.am | 2 +-
osaf/services/saf/immsv/immloadd/imm_loader.cc | 8 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc | 2 +-
osaf/services/saf/immsv/immnd/ImmAttrValue.hh | 2 +
osaf/services/saf/immsv/immnd/ImmModel.cc | 1034 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------
osaf/services/saf/immsv/immnd/ImmModel.hh | 41 +++++-
osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.13.xsd | 180 +++++++++++++++++++++++++
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 4 +-
osaf/tools/safimm/immdump/imm_dumper.cc | 2 +-
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immlist/imm_list.c | 3 +
23 files changed, 1348 insertions(+), 93 deletions(-)
Testing Commands:
-----------------
Testing, Expected Results:
--------------------------
The patches need to support:
- immload support for NO_DANGLING flag
- immdump support for NO_DANGLING flag
- immcfg support for NO_DANGLING flag (immcfg -f)
- immlist support for NO_DANGLING flag (NO_DANGLING flag is listed)
- IMM library support for NO_DANGLING (classCreate - basic checks)
- schema update (adding and removing NO_DANGLING flag)
- default values
- create object (NO_DANGLING attributes with and without values)
- modify object (add, replace and delete)
- delete object
- CCB apply
- CCB abort/terminate
- support for missing objects, created later in the same CCB
Conditions of Submission:
-------------------------
Ack from Neel and Anders
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
|
