#412 Add "xmc xm25qh32c" spi flash id

[eZioPan]

hi, thanks for create such great debug tool!
Would you please add a spi flash id for XMC XM25QH32C?
The code should be

FLASH_ID("xmc xm25qh32c", 0x03, 0x6b, 0x02, 0xd8, 0xc7, 0x00164020, 0x100, 0x1000, 0x400000),

I have test the code on my custom rp2040 board.
here is the product page, and the datasheet

P.S.

In my opinion, there could be plenty of boards with rp2040, and they may carry different qspi flash. It will be great if user can somehow add a Flash_ID without download source code and recompile it.

I would sugguest to extract the FLASH_ID list to a standalone config file, user could modify this file system wide without recompile the software. And add a way to let user specify some tcl command to add a FLASH_ID in their local openocd.cfg. Thanks!

[Andreas Bolsch]

jtagspi and stmqspi drivers do have a command to specify the properties of a flash device at run time. That's not exactly what you described, but reasonable close to it.

So, it's more or less a copy-and-paste of the "jtgaspi set" or "stmqspi set" (see docs) command implementation to another flash driver. As I don't use rp2040 I can't do this, unfortunately.

[eZioPan]

anyway, thanks!

[eZioPan]

and, please consider add flash_id for the "XMC XM25QH32C" I mentioned above, when you got some spare time. thanks!
P.S.
Maybe adjust sectorsize to 0x10000 ?
P.P.S.
the comment on flash_device might not that clear, would you consider rename "sectorsize" to "max_erase_sector_size"?

[Tommy Murphy]

Can't you submit/propose a patch yourself?

• https://github.com/openocd-org/openocd/blob/master/HACKING

[eZioPan]

Sorry for this rude request.But if you can review PR on Github, I will be glad to do a patch. Setup a account on Gerrit is a bit complicated for me.

[Tommy Murphy]

Has to be done via Gerrit.

• https://github.com/openocd-org/openocd

Official OpenOCD Read-Only Mirror (no pull requests)