Menu
▾
▴
#376 configure --enable-verbose triggers compilation error in arm-jtag-ew.c & opendous.c
closed
None
https://review.openocd.org/7403/
2022-12-18
2022-12-17
No
When --enable-verbose is passed to configure it enables code conditionally compiled if _DEBUG_USB_COMMS_ is defined in src/jtag/drivers/arm-jtag-ew.c and src/jtag/drivers/opendous.c which triggers a compilation error.
- https://github.com/openocd-org/openocd/blob/master/src/jtag/drivers/arm-jtag-ew.c#L785
- https://github.com/openocd-org/openocd/blob/master/src/jtag/drivers/opendous.c#L805
This issue has been flagged and discussed in a couple of places already but I cannot find any open OpenOCD ticket or commit relating to it:
- This openocd-dev mailing list thread which seems to have petered out with no action/resolution: https://sourceforge.net/p/openocd/mailman/openocd-devel/thread/20200707144105.180F3819F79D%40turkos.aspodata.se/#msg37055434
- This RISC-V OpenOCD fork isue: https://github.com/riscv/riscv-openocd/issues/771
I can identify potential point fixes/workarounds by changing the code but am not sure what the "correct" and safest one would be.
Please check
https://review.openocd.org/7403/
Hi @borneoa - thanks a lot for the quick reply.
Unfortunately the link that you posted is not responding (502 Proxy Error).
Maybe related to the recently mentioned gerrit problems?
If/when I can get to it I will review the commit.
However expanding the sprintf() len to 9 while not expanding the "width" of the printf specifier from "%04x" does not make sense to me.
Shouldn't the width of the hex specified also be widened or am I missing something here?
Edit: OK - I managed to get to the commit, revive my Ubuntu One login :-) and review it. Thanks again.
Last edit: Tommy Murphy 2022-12-17
Try again the link, The gerrit server becomes not responsive when jenkins is building... painful situation
In the fix I have left "%04x" so the output will not change as I don't expect the length to be more than 64k. In case length exceeds 64k, than "%04x" will simply use more than 4 characters.
I have recomputed the size of the output buffer, it was too big.
Merged