Menu

#196 ath79 flash driver requires CPU address, where core driver passes offset

0.9.0
new
nobody
None
2018-12-26
2018-07-25
No

The ath79 flash driver (src/flash/nor/ath79) expects the "offset" argument to the ath79_read and ath79_write functions to be CPU addresses (which need to be adjusted by subtracting "bank->base" from them).

But, the core flash driver already subtracts "bank->base", so the ath79 flash read/write functions fail. I believe an older version of the core code passed the CPU address (and let the driver subtract bank->base), but this is no longer the case.

I've attached a patch to fix this. I've tested on a QCA9550-based ath79 platform.

1 Attachments

Discussion

  • Tomas Vanek

    Tomas Vanek - 2018-12-26
     

Log in to post a comment.

MongoDB Logo MongoDB