#191 ../src/svf/svf.c:502:7**: error: this statement may fall through [-Werror=implicit-fallthrough=]

[alex]

../src/svf/svf.c:502:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
if (!cmd_pos)
note ! it is not thee same as 190..., different file, different place. sfgit tree doesn't have fix for this bug.
Proposed fixed file attached.
Alex.

[alex]

this is proposed fixes for bugs 19[0,1]

[Antonio Borneo]

Hi Alex,
the file you attached is completely different from the latest version in git.
I have tryed to compare it with all the tracked versions in the history of this file, and the minimal diff is with a version in between OpenOCD v0.4.0 and v0.5.0, something merged between June and December 2010!
Are you sure you have checked against latest version in master branch? It is here:
https://sourceforge.net/p/openocd/code/ci/master/tree/src/svf

[alex]

Hello Antonio! Thank you so much fo r the exact link. I appreciate your help, time & efforts. Finaly I compiled the code and install it properly . Just two little corrections, twhich are actually a typo, were done, please see attached patch file
/src/flash/nor/psoc5lp.c (2 replaced with 3 to account null byte in "xx" string)
and /src/helper/jim-nvp.(<> replaced with""to let gcc find the header file, please double check that jim.h file placed in the master git tree)

[Antonio Borneo]

Hi Alex,

would you mind using gerrit to submit patches? This would let other developers to check and comment.
The way to setup your gerrit account and send patches is explained here:
http://openocd.org/doc-release/doxygen/patchguide.html

Thanks for your contribution
Antonio

[Antonio Borneo]

Hi ALex,

I have proposed in http://openocd.zylin.com/4563 a simpler fix for the compile warning in psoc5lp.c
I would like to have your comments on it

Regarding your proposed change in jim-nvp.h I do not get any compile error and I do not see a reason for it. Can you please describe better the issue?

Antonio