openocd-devel

[OpenOCD-devel] GigaDevice support

[<kri...@te...>]

Hi Marc, Tomas, Karl and others,

I noticed some activity on Gerrit regarding the Risc-V based GigaDevice GD32VF103 microcontroller:
http://openocd.zylin.com/#/c/5839/


I just want to inform all of you that GigaDevice forked OpenOCD a couple of days ago:
https://github.com/GigaDevice-Semiconductor/openocd

In their fork, they're adding support for their chips. It can be a first step to upstream these fixes to the official OpenOCD repo. I'm in contact with some engineers at GigaDevice. They're very kind and helpful, so please don't hesitate to post questions/ideas/issues/... on their GitHub page.

Kind regards,
Kristof Mulier




----- Oorspronkelijk bericht -----
Van: "Marc Schink (Code Review)" <ge...@op...>
Aan: "kristof mulier" <kri...@te...>
Cc: "Tomas Vanek" <va...@fb...>, "Karl Palsson" <ka...@tw...>
Verzonden: Zondag 22 november 2020 11:27:58
Onderwerp: Change in openocd[master]: flash/nor: Add GigaDevice GD32VF103 driver

Marc Schink has posted comments on this change. ( http://openocd.zylin.com/5839 )

Change subject: flash/nor: Add GigaDevice GD32VF103 driver
......................................................................


Patch Set 2:

> More than 70% of code is common for both stm32f1.c and gd32vf103.c In terms of the long term maintenance the duplicated code is pain.

I know but it somehow feels wrong to use the stm32f1 driver for a different MCU family with different architecture. I didn't compare both drivers. Are you sure that we don't need some ugly hacks to make the GD32VF work with the current stm32f1 driver?

-- 
To view, visit http://openocd.zylin.com/5839
To unsubscribe, visit http://openocd.zylin.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia17e1d28649def0e9164e30c2b9163cb57a97029
Gerrit-PatchSet: 2
Gerrit-Project: openocd
Gerrit-Branch: master
Gerrit-Owner: Kristof Mulier <kri...@te...>
Gerrit-Reviewer: Karl Palsson <ka...@tw...>
Gerrit-Reviewer: Marc Schink <de...@za...>
Gerrit-Reviewer: Tomas Vanek <va...@fb...>
Gerrit-Reviewer: jenkins
Gerrit-HasComments: No

Re: [OpenOCD-devel] GigaDevice support

[Tomas V. <to...@us...>]

Hi Kristof,

On 22/11/2020 11:57, kri...@te... wrote:
> Hi Marc, Tomas, Karl and others,
>
> I noticed some activity on Gerrit regarding the Risc-V based GigaDevice GD32VF103 microcontroller:
> http://openocd.zylin.com/#/c/5839/
>
>
> I just want to inform all of you that GigaDevice forked OpenOCD a couple of days ago:
> https://github.com/GigaDevice-Semiconductor/openocd
>
> In their fork, they're adding support for their chips. It can be a first step to upstream these fixes to the official OpenOCD repo. I'm in contact with some engineers at GigaDevice. They're very kind and helpful, so please don't hesitate to post questions/ideas/issues/... on their GitHub page.
>
> Kind regards,
> Kristof Mulier
>

On 29/11/2020 16:06, kri...@te... wrote:
> *2.* GigaDevice recently forked OpenOCD and applied some 
> fixes/additions to support some of their MCUs (see 
> https://github.com/GigaDevice-Semiconductor/openocd ). Maybe it's good 
> to have a look at this fork and merge their fixes with yours? In any 
> case, it would be sad if part of the OpenOCD community keeps working 
> on GigaDevice MCU support in the official OpenOCD repo, and other part 
> of the community (including the GigaDevice engineers) does the same 
> work in their own fork. I think it's good to contact GigaDevice to 
> discuss this - what do you think? I can help with putting you in 
> contact with the right people.
>

I'm afraid you misunderstand how our project works.

http://openocd.org/doc/doxygen/html/patchguide.html clearly states:
------
*Submitting patches to the OpenOCD Gerrit server*
OpenOCD is to some extent a "self service" open source project, so *to 
contribute, you must follow the standard procedures* to have the best 
possible chance to get your changes accepted.
-----
Please believe me, we (maintainers) have no time to gather changes from 
every fork of OpenOCD on github and everywhere.
And moreover if we did so it would be quite unfair to the authors of 
lots of changes which are already waiting in the gerrit.

So if GidaDevice people want to contribute upstream, they can send 
changes to gerrit as anybody other do
(including ST Microelectronics). If they preferred to create a fork, 
it's their business and we can't do anything about it...
If you have a contact to "the right people" please forward him this mail.

Tom

Re: [OpenOCD-devel] GigaDevice support

[<kri...@te...>]

Hi Tomas, 

> "Please believe me, we (maintainers) have no time to gather changes from every fork of OpenOCD on github and everywhere. And moreover if we did so it would be quite unfair to the authors of lots of changes which are already waiting in the gerrit." 

I didn't realize this before. My apologies. I'll contact GigaDevice and explain it to them. 

About the free GigaDevice boards, are you (and/or some of your co-workers) interested? 

Kind regards, 
Kristof Mulier 



Van: "openocd-devel" <ope...@li...> 
Aan: "openocd-devel" <ope...@li...> 
Verzonden: Maandag 30 november 2020 10:50:40 
Onderwerp: Re: [OpenOCD-devel] GigaDevice support 

Hi Kristof, 

On 22/11/2020 11:57, [ mailto:kri...@te... | kri...@te... ] wrote: 



Hi Marc, Tomas, Karl and others,

I noticed some activity on Gerrit regarding the Risc-V based GigaDevice GD32VF103 microcontroller: [ http://openocd.zylin.com/#/c/5839/ | http://openocd.zylin.com/#/c/5839/ ] I just want to inform all of you that GigaDevice forked OpenOCD a couple of days ago: [ https://github.com/GigaDevice-Semiconductor/openocd | https://github.com/GigaDevice-Semiconductor/openocd ] In their fork, they're adding support for their chips. It can be a first step to upstream these fixes to the official OpenOCD repo. I'm in contact with some engineers at GigaDevice. They're very kind and helpful, so please don't hesitate to post questions/ideas/issues/... on their GitHub page.

Kind regards,
Kristof Mulier 



On 29/11/2020 16:06, [ mailto:kri...@te... | kri...@te... ] wrote: 

BQ_BEGIN

2. GigaDevice recently forked OpenOCD and applied some fixes/additions to support some of their MCUs (see [ https://github.com/GigaDevice-Semiconductor/openocd | https://github.com/GigaDevice-Semiconductor/openocd ] ). Maybe it's good to have a look at this fork and merge their fixes with yours? In any case, it would be sad if part of the OpenOCD community keeps working on GigaDevice MCU support in the official OpenOCD repo, and other part of the community (including the GigaDevice engineers) does the same work in their own fork. I think it's good to contact GigaDevice to discuss this - what do you think? I can help with putting you in contact with the right people. 


BQ_END

I'm afraid you misunderstand how our project works. 

[ http://openocd.org/doc/doxygen/html/patchguide.html | http://openocd.org/doc/doxygen/html/patchguide.html ] clearly states: 
------ 
Submitting patches to the OpenOCD Gerrit server 
OpenOCD is to some extent a "self service" open source project, so to contribute, you must follow the standard procedures to have the best possible chance to get your changes accepted. 
----- 
Please believe me, we (maintainers) have no time to gather changes from every fork of OpenOCD on github and everywhere. 
And moreover if we did so it would be quite unfair to the authors of lots of changes which are already waiting in the gerrit. 

So if GidaDevice people want to contribute upstream, they can send changes to gerrit as anybody other do 
(including ST Microelectronics). If they preferred to create a fork, it's their business and we can't do anything about it... 
If you have a contact to "the right people" please forward him this mail. 

Tom 


_______________________________________________ 
OpenOCD-devel mailing list 
Ope...@li... 
https://lists.sourceforge.net/lists/listinfo/openocd-devel