This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via aa2de47d3ce4d484c124f0449702f511aab49112 (commit)
from bac52fbac83f0d04fb51a2547e6ae76fff1ac1dc (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit aa2de47d3ce4d484c124f0449702f511aab49112
Author: Ãyvind Harboe <oyv...@zy...>
Date: Mon Jun 14 09:30:37 2010 +0200
target: fix retval gaffe in mwX commands
failure to write to memory was not propagated.
This is an interesting case of broken error handling:
with exceptions we wouldn't have had this at all,
and I also wonder if there is a GCC option to warn
about these kinds of potential bugs.
Signed-off-by: Ãyvind Harboe <oyv...@zy...>
diff --git a/src/target/target.c b/src/target/target.c
index 01d9441..435d7b6 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -2378,7 +2378,7 @@ static int target_fill_mem(struct target *target,
{
current = chunk_size;
}
- int retval = fn(target, address + x * data_size, data_size, current, target_buf);
+ retval = fn(target, address + x * data_size, data_size, current, target_buf);
if (retval != ERROR_OK)
{
break;
-----------------------------------------------------------------------
Summary of changes:
src/target/target.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|