This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 0b97973bfbb980f987ec8e0e8d8ad32c85e9e5b0 (commit)
from 77f9da76264d4970faf22a40a31fc66fa7543b57 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 0b97973bfbb980f987ec8e0e8d8ad32c85e9e5b0
Author: Marek Vrbka <mar...@co...>
Date: Mon Jan 13 10:28:15 2025 +0100
vdebug: Fix socket comparison warning on Windows
On GCC version 13.2,
the previous code emitted the following warning on Windows:
openocd/src/jtag/drivers/vdebug.c:254:19: warning: comparison of integer expressions of different signedness: 'int' and 'long long unsigned int' [-Wsign-compare]
254 | if (hsock == INVALID_SOCKET)
This patch fixes it and brings it in line with other socket handling code.
Change-Id: I7e05f83c6905cfaf66b68e8988c783e80cee4a48
Signed-off-by: Marek Vrbka <mar...@co...>
Reviewed-on: https://review.openocd.org/c/openocd/+/8717
Tested-by: jenkins
Reviewed-by: Jan Matyas <jan...@co...>
Reviewed-by: Jacek Wuwer <jac...@gm...>
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: R. Diez <rdi...@rd...>
diff --git a/src/jtag/drivers/vdebug.c b/src/jtag/drivers/vdebug.c
index 691e576e5..20819f70b 100644
--- a/src/jtag/drivers/vdebug.c
+++ b/src/jtag/drivers/vdebug.c
@@ -252,7 +252,7 @@ static int vdebug_socket_open(char *server_addr, uint32_t port)
#ifdef _WIN32
hsock = socket(AF_INET, SOCK_STREAM, IPPROTO_IP);
- if (hsock == INVALID_SOCKET)
+ if (hsock < 0)
rc = vdebug_socket_error();
#elif defined __CYGWIN__
/* SO_RCVLOWAT unsupported on CYGWIN */
-----------------------------------------------------------------------
Summary of changes:
src/jtag/drivers/vdebug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|
