|
From: openocd-gerrit <ope...@us...> - 2025-11-30 10:24:49
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 171454fffad3573bdf0870769ae7d82bf07bb8dc (commit)
from fc8f939d95e0b02e5d5dc70023a0ca48fde7aa5d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 171454fffad3573bdf0870769ae7d82bf07bb8dc
Author: Antonio Borneo <bor...@gm...>
Date: Sat Nov 22 22:03:10 2025 +0100
server: fix a new double free()
By reorganizing the free() of the service and its subfields, the
patch reported in 'fixes' exposes a new double free().
Issue detected by 'scan-build'.
Fix it.
Fixes: 5ff384be086a ("semihosting: fix memory leak and double free")
Change-Id: Ief4262e98c9ecdca39d4e2d77e7a0ea87cfa198c
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/9266
Tested-by: jenkins
Reviewed-by: Tomas Vanek <va...@fb...>
diff --git a/src/server/server.c b/src/server/server.c
index 494fd9da3..81d79d41b 100644
--- a/src/server/server.c
+++ b/src/server/server.c
@@ -378,7 +378,6 @@ int remove_service(const char *name, const char *port)
if (tmp->type != CONNECTION_STDINOUT)
close_socket(tmp->fd);
- free(tmp->priv);
free_service(tmp);
return ERROR_OK;
-----------------------------------------------------------------------
Summary of changes:
src/server/server.c | 1 -
1 file changed, 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|