Re: ERROR:EMBEDDED_FILENAME: for changes in configure.ac

[Antonio B. <bor...@gm...>]

On Fri, 17 Oct 2025, 07:17 Agnelo Dcosta, <ag...@qt...> wrote:

> Thoughts on this anyone?
> Let me know if any more information/detail is required.
>
> Thanks,
> Agnelo
>
>
> ------------------------------
> *From:* Agnelo Dcosta (QUIC) <qui...@qu...>
> *Sent:* Thursday, October 9, 2025 5:10 PM
> *To:* openocd-devel <ope...@li...>
> *Cc:* Ashi Gupta <as...@qt...>
> *Subject:* ERROR:EMBEDDED_FILENAME: for changes in configure.ac
>
> Hi.
>
> I am trying to add support for a new debug adapter called EUD(Embedded USB
> Debug) which is inbuilt into Qualcomm chipsets.
> I added the following lines to the <openocd-root-folder>/configure.ac
>
> *-----------------------x------------------------x-------------------------*
> *AS_IF([test "x$enable_eud" != "xno"], [*
> *  AS_IF([test -f "$srcdir/src/jtag/drivers/eud/configure.ac
> <http://configure.ac>"], [*
> *    AX_CONFIG_SUBDIR_OPTION([src/jtag/drivers/eud],
> [--enable-subproject-build])*
> *  ], [*
> *    AC_MSG_ERROR([Internal eud not found, run either 'git submodule init'
> and 'git submodule update' or disable eud with --disable-eud.])*
> *  ])*
> *])*
>
> *-----------------------x------------------------x-------------------------*
>
>
> Running tools/checkpatch.sh on the patch throws up following error
>
> *-----------------------x------------------------x-------------------------*
> ERROR:EMBEDDED_FILENAME: It's generally not useful to have the filename in
> the file
> #720: FILE: configure.ac:720:
> +  AS_IF([test -f "$srcdir/src/jtag/drivers/eud/configure.ac"], [
>
> *-----------------------x------------------------x-------------------------*
>
> On line configure.ac:720, the "configure.ac*" *refers to a different
> configure.ac file under directory  src/jtag/drivers/eud.
> Is there some way to get around this error?
>

Hi,

Checkpatch is not bulletproof and sometimes it screams for nothing.
In the file HACKING is reported how to silent it in specific cases like
this, by adding in the commit message the line
Checkpatch-ignore: EMBEDDED_FILENAME

In OpenOCD we are going to get rid of submodules and we have deprecated all
of them.
What's the value of adding a new one?
Can the driver be upstream in the OpenOCD code directly?
What's the license of the driver's code? Remember that it should be
compatible with the GPLv2 of OpenOCD, either if embedded, or as submodule
or as link-time external library.

Regards
Antonio


>