From: <ge...@op...> - 2025-08-04 16:10:02
|
This is an automated email from Gerrit. "Antonio Borneo <bor...@gm...>" just uploaded a new patch set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9072 -- gerrit commit a4d317714fc0e86d67a6696b75ab3a00434fa843 Author: Antonio Borneo <bor...@gm...> Date: Mon Aug 4 17:45:53 2025 +0200 target: riscv-011: don't change 'debug_level' during target polling In the riscv fork, [1] has disable the debug log during target polling, with message: Improve low-level logging. Now logging is consistent and more readable. I did remove most logging during riscv_poll() since it clutters up the log/screen and is not generally helpful. This is questionable, because if the user enables the debug log, the messages should all be logged. Drop the code that overwrites the 'debug_level'. Link: https://github.com/riscv-collab/riscv-openocd/commit/54c65a9a4b71 [1] Change-Id: Ia86b998cf654760f36c2f217d44bcb9ffd9c3a94 Signed-off-by: Antonio Borneo <bor...@gm...> diff --git a/src/target/riscv/riscv-011.c b/src/target/riscv/riscv-011.c index 15c1c307d7..26189bdc86 100644 --- a/src/target/riscv/riscv-011.c +++ b/src/target/riscv/riscv-011.c @@ -1931,11 +1931,6 @@ static int poll_target(struct target *target, bool announce) { jtag_add_ir_scan(target->tap, &select_dbus, TAP_IDLE); - /* Inhibit debug logging during poll(), which isn't usually interesting and - * just fills up the screen/logs with clutter. */ - int old_debug_level = debug_level; - if (LOG_LEVEL_IS(LOG_LVL_DEBUG)) - debug_level = LOG_LVL_INFO; bits_t bits = { .haltnot = 0, .interrupt = 0 @@ -1943,8 +1938,6 @@ static int poll_target(struct target *target, bool announce) if (read_bits(target, &bits) != ERROR_OK) return ERROR_FAIL; - debug_level = old_debug_level; - if (bits.haltnot && bits.interrupt) { target->state = TARGET_DEBUG_RUNNING; LOG_DEBUG("debug running"); -- |