[PATCH]: cee91144f4 xsvf: prepare for aligning switch and case statements

[<ge...@op...>]

This is an automated email from Gerrit.

"Antonio Borneo <bor...@gm...>" just uploaded a new patch set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9047

-- gerrit

commit cee91144f4c93729325b7d364f49d479c5d2fee6
Author: Antonio Borneo <bor...@gm...>
Date:   Sat Jul 26 13:21:52 2025 +0200

    xsvf: prepare for aligning switch and case statements
    
    To prepare for aligning switch and case statements, fix in advance
    some checkpatch error due to existing code:
    - uniform braces around if/else statements.
    
    While there:
    - drop useless break.
    
    Change-Id: Ic0ce0a9877dbf17c625cf80009a52922176a162d
    Signed-off-by: Antonio Borneo <bor...@gm...>

diff --git a/src/xsvf/xsvf.c b/src/xsvf/xsvf.c
index 617c2f423e..e1cbca41ea 100644
--- a/src/xsvf/xsvf.c
+++ b/src/xsvf/xsvf.c
@@ -349,10 +349,8 @@ COMMAND_HANDLER(handle_xsvf_command)
 				LOG_DEBUG("XCOMPLETE");
 
 				result = jtag_execute_queue();
-				if (result != ERROR_OK) {
+				if (result != ERROR_OK)
 					tdo_mismatch = 1;
-					break;
-				}
 				break;
 
 			case XTDOMASK:
@@ -380,9 +378,9 @@ COMMAND_HANDLER(handle_xsvf_command)
 			{
 				uint8_t myrepeat;
 
-				if (read(xsvf_fd, &myrepeat, 1) < 0)
+				if (read(xsvf_fd, &myrepeat, 1) < 0) {
 					do_abort = 1;
-				else {
+				} else {
 					xrepeat = myrepeat;
 					LOG_DEBUG("XREPEAT %d", xrepeat);
 				}
@@ -614,11 +612,11 @@ COMMAND_HANDLER(handle_xsvf_command)
 				}
 
 				/* see page 22 of XSVF spec */
-				if (uc == 0)
+				if (uc == 0) {
 					xendir = TAP_IDLE;
-				else if (uc == 1)
+				} else if (uc == 1) {
 					xendir = TAP_IRPAUSE;
-				else {
+				} else {
 					LOG_ERROR("illegial XENDIR argument: 0x%02X", uc);
 					unsupported = 1;
 					break;
@@ -635,11 +633,11 @@ COMMAND_HANDLER(handle_xsvf_command)
 				}
 
 				/* see page 22 of XSVF spec */
-				if (uc == 0)
+				if (uc == 0) {
 					xenddr = TAP_IDLE;
-				else if (uc == 1)
+				} else if (uc == 1) {
 					xenddr = TAP_DRPAUSE;
-				else {
+				} else {
 					LOG_ERROR("illegial XENDDR argument: 0x%02X", uc);
 					unsupported = 1;
 					break;
@@ -675,9 +673,9 @@ COMMAND_HANDLER(handle_xsvf_command)
 
 				ir_buf = malloc((bitcount + 7) / 8);
 
-				if (xsvf_read_buffer(bitcount, xsvf_fd, ir_buf) != ERROR_OK)
+				if (xsvf_read_buffer(bitcount, xsvf_fd, ir_buf) != ERROR_OK) {
 					do_abort = 1;
-				else {
+				} else {
 					struct scan_field field;
 
 					field.num_bits = bitcount;
@@ -762,9 +760,9 @@ COMMAND_HANDLER(handle_xsvf_command)
 				LOG_DEBUG("XWAIT %s %s usecs:%d", tap_state_name(
 						wait_state), tap_state_name(end_state), delay);
 
-				if (runtest_requires_tck && wait_state == TAP_IDLE)
+				if (runtest_requires_tck && wait_state == TAP_IDLE) {
 					jtag_add_runtest(delay, end_state);
-				else {
+				} else {
 					/* FIXME handle statemove errors ... */
 					result = svf_add_statemove(wait_state);
 					if (result != ERROR_OK)

--