From: openocd-gerrit <ope...@us...> - 2025-03-01 15:13:07
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Main OpenOCD repository". The branch, master has been updated via accbeaed99bc6014d060259d6b0b0e080c0f44b4 (commit) from c986b4dbf2ff81753adcd0235954cfd577831672 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit accbeaed99bc6014d060259d6b0b0e080c0f44b4 Author: Jim Paris <jim...@me...> Date: Fri Feb 21 12:33:45 2025 -0500 gdb_server: fix invalid free `gdb_service_free` calls `free(gdb_port_next)`, so this needs to be an allocated string. Otherwise we trip up detectors like Android's tagged pointers. Change-Id: Ib08ea55a38af4e15c4fbae95f10db0e3684ae1af Signed-off-by: Jim Paris <jim...@me...> Reviewed-on: https://review.openocd.org/c/openocd/+/8768 Reviewed-by: Tomas Vanek <va...@fb...> Reviewed-by: Antonio Borneo <bor...@gm...> Tested-by: jenkins diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c index 1866de0b5..71b7c7764 100644 --- a/src/server/gdb_server.c +++ b/src/server/gdb_server.c @@ -3898,7 +3898,8 @@ static int gdb_target_add_one(struct target *target) } } } else if (strcmp(gdb_port_next, "pipe") == 0) { - gdb_port_next = "disabled"; + free(gdb_port_next); + gdb_port_next = strdup("disabled"); } } return retval; ----------------------------------------------------------------------- Summary of changes: src/server/gdb_server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- Main OpenOCD repository |