From: openocd-gerrit <ope...@us...> - 2024-11-23 13:48:28
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Main OpenOCD repository". The branch, master has been updated via b04a58e3fcbfd9a701126473279fa17d37f23784 (commit) via df42faf51d20d879beefacbd88b11271bcee181a (commit) from c5babec7949d3fc23fd3fe43d5452897b7c94553 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b04a58e3fcbfd9a701126473279fa17d37f23784 Author: Antonio Borneo <bor...@gm...> Date: Sat Nov 9 19:46:03 2024 +0100 target: esirisc: make local functions static The function esirisc_jtag_get_eid() is not used outside the file. Make it static. The function esirisc_jtag_disable_debug() is never used. Make it static and mark it as unused. Change-Id: I5c99cbf77cc9c527b6e18a3f67caa24f8551d09c Signed-off-by: Antonio Borneo <bor...@gm...> Reviewed-on: https://review.openocd.org/c/openocd/+/8550 Tested-by: jenkins diff --git a/src/target/esirisc_jtag.c b/src/target/esirisc_jtag.c index 5960e26cb..ad2bef543 100644 --- a/src/target/esirisc_jtag.c +++ b/src/target/esirisc_jtag.c @@ -19,6 +19,8 @@ #include "esirisc_jtag.h" +static uint8_t esirisc_jtag_get_eid(struct esirisc_jtag *jtag_info); + static void esirisc_jtag_set_instr(struct esirisc_jtag *jtag_info, uint32_t new_instr) { struct jtag_tap *tap = jtag_info->tap; @@ -221,7 +223,7 @@ bool esirisc_jtag_is_stopped(struct esirisc_jtag *jtag_info) return !!(jtag_info->status & 1<<6); /* S */ } -uint8_t esirisc_jtag_get_eid(struct esirisc_jtag *jtag_info) +static uint8_t esirisc_jtag_get_eid(struct esirisc_jtag *jtag_info) { return jtag_info->status & 0x3f; /* EID */ } @@ -490,7 +492,7 @@ int esirisc_jtag_enable_debug(struct esirisc_jtag *jtag_info) return esirisc_jtag_send_ctrl(jtag_info, DEBUG_ENABLE_DEBUG); } -int esirisc_jtag_disable_debug(struct esirisc_jtag *jtag_info) +static __attribute__((unused)) int esirisc_jtag_disable_debug(struct esirisc_jtag *jtag_info) { return esirisc_jtag_send_ctrl(jtag_info, DEBUG_DISABLE_DEBUG); } diff --git a/src/target/esirisc_jtag.h b/src/target/esirisc_jtag.h index 98ec8af8d..d59b75fbe 100644 --- a/src/target/esirisc_jtag.h +++ b/src/target/esirisc_jtag.h @@ -54,7 +54,6 @@ struct esirisc_jtag { bool esirisc_jtag_is_debug_active(struct esirisc_jtag *jtag_info); bool esirisc_jtag_is_stopped(struct esirisc_jtag *jtag_info); -uint8_t esirisc_jtag_get_eid(struct esirisc_jtag *jtag_info); int esirisc_jtag_read_byte(struct esirisc_jtag *jtag_info, uint32_t address, uint8_t *data); @@ -81,7 +80,6 @@ int esirisc_jtag_write_csr(struct esirisc_jtag *jtag_info, uint8_t bank, uint8_t csr, uint32_t data); int esirisc_jtag_enable_debug(struct esirisc_jtag *jtag_info); -int esirisc_jtag_disable_debug(struct esirisc_jtag *jtag_info); int esirisc_jtag_assert_reset(struct esirisc_jtag *jtag_info); int esirisc_jtag_deassert_reset(struct esirisc_jtag *jtag_info); commit df42faf51d20d879beefacbd88b11271bcee181a Author: Antonio Borneo <bor...@gm...> Date: Sat Nov 9 19:12:46 2024 +0100 target: aarch64: drop unused armv8_mmu_translate_va() The function is not used. Drop it! Change-Id: I1625e03714b5a842f668098191c39cce34f815e8 Signed-off-by: Antonio Borneo <bor...@gm...> Reviewed-on: https://review.openocd.org/c/openocd/+/8549 Tested-by: jenkins diff --git a/src/target/armv8.c b/src/target/armv8.c index 61d72741a..88534d962 100644 --- a/src/target/armv8.c +++ b/src/target/armv8.c @@ -1021,12 +1021,6 @@ static __attribute__((unused)) void armv8_show_fault_registers(struct target *ta armv8_show_fault_registers32(armv8); } -/* method adapted to cortex A : reused arm v4 v5 method*/ -int armv8_mmu_translate_va(struct target *target, target_addr_t va, target_addr_t *val) -{ - return ERROR_OK; -} - static void armv8_decode_cacheability(int attr) { if (attr == 0) { diff --git a/src/target/armv8.h b/src/target/armv8.h index 349c8f002..49ab3e5cb 100644 --- a/src/target/armv8.h +++ b/src/target/armv8.h @@ -298,7 +298,6 @@ int armv8_identify_cache(struct armv8_common *armv8); int armv8_init_arch_info(struct target *target, struct armv8_common *armv8); int armv8_mmu_translate_va_pa(struct target *target, target_addr_t va, target_addr_t *val, int meminfo); -int armv8_mmu_translate_va(struct target *target, target_addr_t va, target_addr_t *val); int armv8_handle_cache_info_command(struct command_invocation *cmd, struct armv8_cache_common *armv8_cache); ----------------------------------------------------------------------- Summary of changes: src/target/armv8.c | 6 ------ src/target/armv8.h | 1 - src/target/esirisc_jtag.c | 6 ++++-- src/target/esirisc_jtag.h | 2 -- 4 files changed, 4 insertions(+), 11 deletions(-) hooks/post-receive -- Main OpenOCD repository |