|
From: openocd-gerrit <ope...@us...> - 2024-10-05 15:49:09
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 66006d83b99843ab7c6ec19125e2fc20855a4c7c (commit)
via 39197cdb4ee8f7ed605308a07bac67b33fb4973f (commit)
from 4214fca4478404fff21110fd8ce5b4dc9ccfa72a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 66006d83b99843ab7c6ec19125e2fc20855a4c7c
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 16 11:37:05 2024 +0200
target: drop comparison to NULL
Fix checkpatch error:
ERROR:COMPARISON_TO_NULL: Comparison to NULL could be
written "cmd_ctx"
Change-Id: I3615fc427f8b160d44b6edbf7a066a086cab99bb
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/8495
Tested-by: jenkins
Reviewed-by: zapb <de...@za...>
diff --git a/src/target/target.c b/src/target/target.c
index 56aa8b1e7..2be8b24b9 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -4596,7 +4596,7 @@ static int target_jim_write_memory(Jim_Interp *interp, int argc,
}
struct command_context *cmd_ctx = current_command_context(interp);
- assert(cmd_ctx != NULL);
+ assert(cmd_ctx);
struct target *target = get_current_target(cmd_ctx);
const size_t buffersize = 4096;
@@ -4739,7 +4739,7 @@ static int target_jim_get_reg(Jim_Interp *interp, int argc,
return JIM_ERR;
struct command_context *cmd_ctx = current_command_context(interp);
- assert(cmd_ctx != NULL);
+ assert(cmd_ctx);
const struct target *target = get_current_target(cmd_ctx);
for (int i = 0; i < length; i++) {
commit 39197cdb4ee8f7ed605308a07bac67b33fb4973f
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 16 11:36:03 2024 +0200
jtag: stlink_usb: drop comparison to NULL
Fix checkpatch error:
ERROR:COMPARISON_TO_NULL: Comparison to NULL could be
written "handle"
Change-Id: I0ac12ccfc5fce4dd41266f83eb4b973a4e6a314d
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/8494
Reviewed-by: zapb <de...@za...>
Tested-by: jenkins
diff --git a/src/jtag/drivers/stlink_usb.c b/src/jtag/drivers/stlink_usb.c
index 812a192c2..0385e4d85 100644
--- a/src/jtag/drivers/stlink_usb.c
+++ b/src/jtag/drivers/stlink_usb.c
@@ -2754,7 +2754,7 @@ static int stlink_usb_read_mem32_noaddrinc(void *handle, uint8_t ap_num, uint32_
{
struct stlink_usb_handle *h = handle;
- assert(handle != NULL);
+ assert(handle);
if (!(h->version.flags & STLINK_F_HAS_MEM_RD_NO_INC))
return ERROR_COMMAND_NOTFOUND;
@@ -2796,7 +2796,7 @@ static int stlink_usb_write_mem32_noaddrinc(void *handle, uint8_t ap_num, uint32
{
struct stlink_usb_handle *h = handle;
- assert(handle != NULL);
+ assert(handle);
if (!(h->version.flags & STLINK_F_HAS_MEM_WR_NO_INC))
return ERROR_COMMAND_NOTFOUND;
@@ -3947,7 +3947,7 @@ static int stlink_usb_rw_misc_out(void *handle, uint32_t items, const uint8_t *b
LOG_DEBUG_IO("%s(%" PRIu32 ")", __func__, items);
- assert(handle != NULL);
+ assert(handle);
if (!(h->version.flags & STLINK_F_HAS_RW_MISC))
return ERROR_COMMAND_NOTFOUND;
@@ -3968,7 +3968,7 @@ static int stlink_usb_rw_misc_in(void *handle, uint32_t items, uint8_t *buffer)
LOG_DEBUG_IO("%s(%" PRIu32 ")", __func__, items);
- assert(handle != NULL);
+ assert(handle);
if (!(h->version.flags & STLINK_F_HAS_RW_MISC))
return ERROR_COMMAND_NOTFOUND;
-----------------------------------------------------------------------
Summary of changes:
src/jtag/drivers/stlink_usb.c | 8 ++++----
src/target/target.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|