From: openocd-gerrit <ope...@us...> - 2024-09-15 09:07:39
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Main OpenOCD repository". The branch, master has been updated via d35399b00e5693d5b6f91208b0f52e5d710d086f (commit) from 6f9b1ee521203f0d43b7d84e671ba4e32bd3e599 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d35399b00e5693d5b6f91208b0f52e5d710d086f Author: daniellizewski <dan...@ge...> Date: Fri Aug 23 08:31:04 2024 -0400 src/flash/nor/kinetis.c: Fixed flash bank write gap Flash banks created in kinetis_create_missing_banks did not populate bank->minimal_write_gap. The default value of 0 was interpreted as FLASH_WRITE_CONTINUOUS. This created unnecessary large padding if your binary had a gap in the populated flash. It also caused flash errors when loading with GDB because the erroneously padded pages were not erased first. Tested using an S32k148 using s32k.cfg. Change-Id: I9b7af698e29ac2c4f5fc8ecd82fa7f4b1a0d43f1 Signed-off-by: daniellizewski <dan...@ge...> Reviewed-on: https://review.openocd.org/c/openocd/+/8463 Tested-by: jenkins Reviewed-by: Antonio Borneo <bor...@gm...> Reviewed-by: Tomas Vanek <va...@fb...> diff --git a/src/flash/nor/kinetis.c b/src/flash/nor/kinetis.c index fee36444e..2d0a75334 100644 --- a/src/flash/nor/kinetis.c +++ b/src/flash/nor/kinetis.c @@ -1038,6 +1038,7 @@ static int kinetis_create_missing_banks(struct kinetis_chip *k_chip) bank->target = k_chip->target; bank->driver = &kinetis_flash; bank->default_padded_value = bank->erased_value = 0xff; + bank->minimal_write_gap = FLASH_WRITE_GAP_SECTOR; snprintf(name, sizeof(name), "%s.%s%s", base_name, class, num); ----------------------------------------------------------------------- Summary of changes: src/flash/nor/kinetis.c | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- Main OpenOCD repository |