[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.12.0-524-g07141132a

[openocd-gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  07141132a7d787005c0829618a60b4a842be7847 (commit)
      from  271c4e5253abcd2ec617d5fb5e1a374d2b6a543d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 07141132a7d787005c0829618a60b4a842be7847
Author: Antonio Borneo <bor...@gm...>
Date:   Sat Dec 4 00:48:23 2021 +0100

    gdb_server: don't send unrequested ACK at connection
    
    On 2008-03-05, before git's age, commit 6d9501467441 adds sending
    an ACK ('+' char) at GDB connection, before receiving any GDB
    remote command that requires to be ACK'ed.
    
    Neither the text added in the commit message ("added ACK upon
    connection (send +)") nor in the associated comment ("send ACK to
    GDB for debug request") provide an exhaustive explanation for
    sending this unsolicited ACK.
    
    This code has never been touched since its introduction.
    
    Analysis of GDB code doesn't show it's required, including old GDB
    code.
    Running gdbserver (from GDB package) and attaching it with "nc"
    shows that gdbserver does not send any ACK to a new connection.
    Same for lldb-server.
    
    Drop it!
    
    Change-Id: Id68c352ce44dd85a1ea3d67446e17e2a241ef058
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Reviewed-on: https://review.openocd.org/c/openocd/+/6768
    Tested-by: jenkins
    Reviewed-by: Jan Matyas <jan...@co...>
    Reviewed-by: Anatoly P <ana...@sy...>
    Reviewed-by: Tomas Vanek <va...@fb...>

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index 13bc23395..b14068941 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -1001,9 +1001,6 @@ static int gdb_new_connection(struct connection *connection)
 	gdb_connection->output_flag = GDB_OUTPUT_NO;
 	gdb_connection->unique_index = next_unique_id++;
 
-	/* send ACK to GDB for debug request */
-	gdb_write(connection, "+", 1);
-
 	/* output goes through gdb connection */
 	command_set_output_handler(connection->cmd_ctx, gdb_output, connection);
 

-----------------------------------------------------------------------

Summary of changes:
 src/server/gdb_server.c | 3 ---
 1 file changed, 3 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository