[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.12.0-493-g43e1d60e7

[openocd-gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  43e1d60e77b7984e21a9250a530a34f64bab78c0 (commit)
      from  ea2e26f7d521f5755b4bfda7bf12d99650277421 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 43e1d60e77b7984e21a9250a530a34f64bab78c0
Author: Tomas Vanek <va...@fb...>
Date:   Sun Dec 10 15:03:46 2023 +0100

    jtag/drivers/cmsis_dap_usb_bulk: fix clang warning
    
    Clang static analyzer warnings
    "1st function call argument is an uninitialized value"
    on the first libusb_free_transfer() parameter (lines 423, 424)
    could turn into a real problem in a corner case:
    If allocation of a libusb transfer struct fails, the pointers of not yet
    allocated transfers remain uninitialized.
    
    Use calloc() to zero whole struct cmsis_dap_backend_data.
    
    Fixes: fd75e9e54270 (jtag/drivers/cmsis_dap_bulk: use asynchronous libusb transfer)
    Signed-off-by: Tomas Vanek <va...@fb...>
    Change-Id: I0e489757d82d10ed7416c5e8c215e1facc7f8093
    Reviewed-on: https://review.openocd.org/c/openocd/+/8045
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <bor...@gm...>

diff --git a/src/jtag/drivers/cmsis_dap_usb_bulk.c b/src/jtag/drivers/cmsis_dap_usb_bulk.c
index 92a972a04..8d0cb544d 100644
--- a/src/jtag/drivers/cmsis_dap_usb_bulk.c
+++ b/src/jtag/drivers/cmsis_dap_usb_bulk.c
@@ -362,7 +362,7 @@ static int cmsis_dap_usb_open(struct cmsis_dap *dap, uint16_t vids[], uint16_t p
 			if (err)
 				LOG_WARNING("could not claim interface: %s", libusb_strerror(err));
 
-			dap->bdata = malloc(sizeof(struct cmsis_dap_backend_data));
+			dap->bdata = calloc(1, sizeof(struct cmsis_dap_backend_data));
 			if (!dap->bdata) {
 				LOG_ERROR("unable to allocate memory");
 				libusb_release_interface(dev_handle, interface_num);

-----------------------------------------------------------------------

Summary of changes:
 src/jtag/drivers/cmsis_dap_usb_bulk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
Main OpenOCD repository