From: openocd-gerrit <ope...@us...> - 2023-11-11 18:04:28
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Main OpenOCD repository". The branch, master has been updated via 7d1f132cea58017003534a45ad444e55c23fd5be (commit) via cca530c09df312927291f27b010088d38342b1d4 (commit) via f58b5ddaf27d899eca72c8707e32f1c3cfc25551 (commit) from 59c4d35fa43d39b195510c9d1d415435912dcaed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d1f132cea58017003534a45ad444e55c23fd5be Author: Marek Vrbka <mar...@co...> Date: Fri Nov 3 10:48:02 2023 +0100 target: Fix get_reg, prevent returning invalid data This patch forces a read of register from the target in the get_reg command in case the register cache does not hold a valid value at that moment. Note that the command "reg" already handles it correctly, no fix is needed there. Change-Id: I75fad25188e94ee4e06162ab6d600ea24dbf590a Signed-off-by: Marek Vrbka <mar...@co...> Reviewed-on: https://review.openocd.org/c/openocd/+/7958 Reviewed-by: Jan Matyas <jan...@co...> Reviewed-by: zapb <de...@za...> Reviewed-by: Antonio Borneo <bor...@gm...> Tested-by: jenkins diff --git a/src/target/target.c b/src/target/target.c index 384b4ec84..61c243510 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -5149,7 +5149,7 @@ static int target_jim_get_reg(Jim_Interp *interp, int argc, return JIM_ERR; } - if (force) { + if (force || !reg->valid) { int retval = reg->type->get(reg); if (retval != ERROR_OK) { commit cca530c09df312927291f27b010088d38342b1d4 Author: Oliver Graute <oli...@ko...> Date: Wed Nov 1 22:46:33 2023 +0100 tcl/board: add board configuration for Advantech IMX8QM DMSSE20 Change-Id: Iebf2a901b428cf3b99110aea0f3ab0e1f17b0250 Signed-off-by: Oliver Graute <oli...@ko...> Reviewed-on: https://review.openocd.org/c/openocd/+/7974 Reviewed-by: Antonio Borneo <bor...@gm...> Tested-by: jenkins Reviewed-by: zapb <de...@za...> diff --git a/tcl/board/advantech_imx8qm_dmsse20.cfg b/tcl/board/advantech_imx8qm_dmsse20.cfg new file mode 100644 index 000000000..a867b2de0 --- /dev/null +++ b/tcl/board/advantech_imx8qm_dmsse20.cfg @@ -0,0 +1,23 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# +# configuration file for Advantech IMX8QM DMSSE20 +# + +# only JTAG supported +transport select jtag + +# set a safe JTAG clock speed, can be overridden +adapter speed 1000 + +# default JTAG configuration has only SRST and no TRST +reset_config srst_only srst_push_pull + +# delay after SRST goes inactive +adapter srst delay 70 + +# board has an i.MX8QM with 4 Cortex-A53 cores and 2 Cortex-A72 +set CHIPNAME imx8qm +set CHIPCORES 6 + +# source SoC configuration +source [find tcl/target/imx8qm.cfg] commit f58b5ddaf27d899eca72c8707e32f1c3cfc25551 Author: Marc Schink <de...@za...> Date: Fri Nov 3 11:04:08 2023 +0100 target/target: Use boolean values for 'valid' flag Change-Id: Ieaa25b9ef0997c0f75ddfb652325c1a9e53a8d8d Signed-off-by: Marc Schink <de...@za...> Reviewed-on: https://review.openocd.org/c/openocd/+/7959 Tested-by: jenkins Reviewed-by: Antonio Borneo <bor...@gm...> Reviewed-by: Jan Matyas <jan...@co...> diff --git a/src/target/target.c b/src/target/target.c index 10d0088d5..384b4ec84 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -3139,9 +3139,9 @@ COMMAND_HANDLER(handle_reg_command) if ((CMD_ARGC == 1) || ((CMD_ARGC == 2) && !((CMD_ARGV[1][0] >= '0') && (CMD_ARGV[1][0] <= '9')))) { if ((CMD_ARGC == 2) && (strcmp(CMD_ARGV[1], "force") == 0)) - reg->valid = 0; + reg->valid = false; - if (reg->valid == 0) { + if (!reg->valid) { int retval = reg->type->get(reg); if (retval != ERROR_OK) { LOG_ERROR("Could not read register '%s'", reg->name); ----------------------------------------------------------------------- Summary of changes: src/target/target.c | 6 +++--- .../{nxp_mcimx8m-evk.cfg => advantech_imx8qm_dmsse20.cfg} | 11 +++++------ 2 files changed, 8 insertions(+), 9 deletions(-) copy tcl/board/{nxp_mcimx8m-evk.cfg => advantech_imx8qm_dmsse20.cfg} (64%) hooks/post-receive -- Main OpenOCD repository |