[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.12.0-307-gea0ac6dc7

[openocd-gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  ea0ac6dc779f09fd21e007d93987a6a7eca5149e (commit)
      from  aee495e7859d0f19b52ba12cafaad2628d84f8e1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ea0ac6dc779f09fd21e007d93987a6a7eca5149e
Author: Brandon Pupp <bp...@xe...>
Date:   Fri Aug 18 09:51:06 2023 -0500

    jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output
    
    Previously, if a pin was configured as ADAPTER_GPIO_INIT_STATE_INPUT and
    its drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL, initialize_gpio
    would configure the pin as an output.
    
    The set_gpio_value function is optimized to not set the direction for
    pins configured as ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL as it only needs to
    be set once. When initialize_gpio performs this setup, it checked only
    that the drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the
    output direction but did not exclude input pins which have already had
    their direction set.
    
    Now, input pins are ignored when initialize_gpio checks for
    ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the mode to output.
    
    Change-Id: I4fc7a8132a6b00c7f213ec9fd05c7bbb37ee5f20
    Fixes: 0dd969d83bad ("drivers/bcm2835gpio: Migrate to adapter gpio commands")
    Signed-off-by: Brandon Pupp <bp...@xe...>
    [vfazio: update commit message]
    Signed-off-by: Vincent Fazio <vf...@xe...>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7862
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <va...@fb...>

diff --git a/src/jtag/drivers/bcm2835gpio.c b/src/jtag/drivers/bcm2835gpio.c
index 39e4af365..f41f7b51e 100644
--- a/src/jtag/drivers/bcm2835gpio.c
+++ b/src/jtag/drivers/bcm2835gpio.c
@@ -167,7 +167,8 @@ static void initialize_gpio(enum adapter_gpio_config_index idx)
 	}
 
 	/* Direction for non push-pull is already set by set_gpio_value() */
-	if (adapter_gpio_config[idx].drive == ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL)
+	if (adapter_gpio_config[idx].drive == ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL
+		&& adapter_gpio_config[idx].init_state != ADAPTER_GPIO_INIT_STATE_INPUT)
 		OUT_GPIO(adapter_gpio_config[idx].gpio_num);
 	bcm2835_gpio_synchronize();
 }

-----------------------------------------------------------------------

Summary of changes:
 src/jtag/drivers/bcm2835gpio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Main OpenOCD repository