|
From: openocd-gerrit <ope...@us...> - 2023-05-13 09:24:52
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 3a4f445bd92101d3daee3715178d3fbff3b7b029 (commit)
from 8d12ae796ead267aeef48467ccd49ec4c2f863ad (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3a4f445bd92101d3daee3715178d3fbff3b7b029
Author: Paul Fertser <fer...@gm...>
Date: Tue May 2 15:15:21 2023 +0300
jtag: tcl: show error message when attempting manual "drscan" on a bypassed tap
To perform any meaningful manipulations with DR the corresponding IR should
be set to a relevant instruction, not BYPASS, so warn the user accordingly.
Signed-off-by: Paul Fertser <fer...@gm...>
Change-Id: I42580ecd75ae824a4145f6f17f0df9bcf825b50f
Reviewed-on: https://review.openocd.org/c/openocd/+/7654
Reviewed-by: Antonio Borneo <bor...@gm...>
Tested-by: jenkins
diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c
index 395439039..934b60352 100644
--- a/src/jtag/tcl.c
+++ b/src/jtag/tcl.c
@@ -116,6 +116,11 @@ COMMAND_HANDLER(handle_jtag_command_drscan)
return ERROR_COMMAND_ARGUMENT_INVALID;
}
+ if (tap->bypass) {
+ command_print(CMD, "Can't execute as the selected tap is in BYPASS");
+ return ERROR_FAIL;
+ }
+
tap_state_t endstate = TAP_IDLE;
if (CMD_ARGC > 3 && !strcmp("-endstate", CMD_ARGV[CMD_ARGC - 2])) {
const char *state_name = CMD_ARGV[CMD_ARGC - 1];
-----------------------------------------------------------------------
Summary of changes:
src/jtag/tcl.c | 5 +++++
1 file changed, 5 insertions(+)
hooks/post-receive
--
Main OpenOCD repository
|