[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.12.0-176-g57f7ce68a

[openocd-gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  57f7ce68a48b03bcd198a009fc9c75fe3948c0db (commit)
      from  d771d7f1a7d0181b4670c7c3ddb83ba8b8eb7da0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 57f7ce68a48b03bcd198a009fc9c75fe3948c0db
Author: Antonio Borneo <bor...@gm...>
Date:   Sun Apr 30 22:57:59 2023 +0200

    pld: gatemate: fix memory leak
    
    When gatemate_set_instr() fails, the array pointed by
    bit_file.raw_file.data is not freed.
    Issue identified by OpenOCD Jenkins clang build.
    
    Free the array while propagating the error.
    
    Change-Id: I2f7fadee903f9c65cdc9ab9b52ccb5803b48a59d
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Fixes: 682f927f8e4e ("pld: add support for cologne chip gatemate fpgas")
    Reviewed-on: https://review.openocd.org/c/openocd/+/7632
    Tested-by: jenkins
    Reviewed-by: Daniel Anselmi <dan...@gm...>

diff --git a/src/pld/gatemate.c b/src/pld/gatemate.c
index afd27efca..43b3f02d1 100644
--- a/src/pld/gatemate.c
+++ b/src/pld/gatemate.c
@@ -192,8 +192,10 @@ static int gatemate_load(struct pld_device *pld_device, const char *filename)
 		return retval;
 
 	retval = gatemate_set_instr(tap, JTAG_CONFIGURE);
-	if (retval != ERROR_OK)
+	if (retval != ERROR_OK) {
+		free(bit_file.raw_file.data);
 		return retval;
+	}
 
 	struct scan_field field;
 	field.num_bits = bit_file.raw_file.length * 8;

-----------------------------------------------------------------------

Summary of changes:
 src/pld/gatemate.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Main OpenOCD repository