[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.12.0-rc2-6-g5fc4882b8

[OpenOCD-Gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  5fc4882b8039dbd35f2efcd1419e83fbda9eba28 (commit)
      from  0946e80407150b68acd02bc59f0f3a3170142c4c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5fc4882b8039dbd35f2efcd1419e83fbda9eba28
Author: Antonio Borneo <bor...@gm...>
Date:   Wed Nov 2 01:13:49 2022 +0100

    dsp5680xx: fix clang error core.UndefinedBinaryOperatorResult
    
    Clang get confused by initializing the array uint16_t lock_word[],
    casting it to (uint8_t *), then accessing the second element of
    the uint8_t pointer.
    
      src/target/dsp5680xx.c:2046:41: warning: The left operand of '<<'
        is a garbage value [core.UndefinedBinaryOperatorResult]
            uint16_t tmp = (buffer[0] | (buffer[1] << 8));
                                         ~~~~~~~~~ ^
    Fix it by replacing the array with a single uint16_t.
    
    The code is still depending on host endianness; no fix for this is
    proposed.
    
    Change-Id: I16dfd60cab117dd145aeecf10d9593574ff233a2
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7302
    Tested-by: jenkins

diff --git a/src/target/dsp5680xx.c b/src/target/dsp5680xx.c
index 37cf0590d..c90bca3c1 100644
--- a/src/target/dsp5680xx.c
+++ b/src/target/dsp5680xx.c
@@ -2200,8 +2200,8 @@ int dsp5680xx_f_lock(struct target *target)
 	struct jtag_tap *tap_chp;
 
 	struct jtag_tap *tap_cpu;
-	uint16_t lock_word[] = { HFM_LOCK_FLASH };
-	retval = dsp5680xx_f_wr(target, (uint8_t *) (lock_word), HFM_LOCK_ADDR_L, 2, 1);
+	uint16_t lock_word = HFM_LOCK_FLASH;
+	retval = dsp5680xx_f_wr(target, (uint8_t *)&lock_word, HFM_LOCK_ADDR_L, 2, 1);
 	err_check_propagate(retval);
 
 	jtag_add_reset(0, 1);

-----------------------------------------------------------------------

Summary of changes:
 src/target/dsp5680xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository