[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.11.0-797-gc3138e2d8

[OpenOCD-Gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  c3138e2d805b94b81ba10bc7fcec47689704f60e (commit)
      from  9903203d73c9243c327db9dc0d726491bb625d41 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c3138e2d805b94b81ba10bc7fcec47689704f60e
Author: Ian Thompson <ia...@ca...>
Date:   Mon Aug 1 15:22:32 2022 -0700

    gdb_server: add "not supported" Z-packet reply
    
    GDB remote serial protocol specifies breakpoint/watchpoint packet
    responses can be an empty string to indicate the specified breakpoint
    type is not supported.  Add support for this response alongside existing
    "OK", "E NN" replies.
    
    Signed-off-by: Ian Thompson <ia...@ca...>
    Change-Id: Iaf6280e4c936eb95a92bc80cc74d451ebb328dc3
    Reviewed-on: https://review.openocd.org/c/openocd/+/7102
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <bor...@gm...>

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index 2e6c7304d..28833c9ce 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -1770,7 +1770,10 @@ static int gdb_breakpoint_watchpoint_packet(struct connection *connection,
 		case 1:
 			if (packet[0] == 'Z') {
 				retval = breakpoint_add(target, address, size, bp_type);
-				if (retval != ERROR_OK) {
+				if (retval == ERROR_NOT_IMPLEMENTED) {
+					/* Send empty reply to report that breakpoints of this type are not supported */
+					gdb_put_packet(connection, "", 0);
+				} else if (retval != ERROR_OK) {
 					retval = gdb_error(connection, retval);
 					if (retval != ERROR_OK)
 						return retval;
@@ -1787,7 +1790,10 @@ static int gdb_breakpoint_watchpoint_packet(struct connection *connection,
 		{
 			if (packet[0] == 'Z') {
 				retval = watchpoint_add(target, address, size, wp_type, 0, 0xffffffffu);
-				if (retval != ERROR_OK) {
+				if (retval == ERROR_NOT_IMPLEMENTED) {
+					/* Send empty reply to report that watchpoints of this type are not supported */
+					gdb_put_packet(connection, "", 0);
+				} else if (retval != ERROR_OK) {
 					retval = gdb_error(connection, retval);
 					if (retval != ERROR_OK)
 						return retval;

-----------------------------------------------------------------------

Summary of changes:
 src/server/gdb_server.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository