[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.11.0-362-g12e2dfd31

[OpenOCD-Gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  12e2dfd31ff07d9d13c7f66b799fad90a2698428 (commit)
      from  b3a51bbb590cca6d6536532d8c0965748410f277 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 12e2dfd31ff07d9d13c7f66b799fad90a2698428
Author: Antonio Borneo <bor...@gm...>
Date:   Sat May 15 23:14:18 2021 +0200

    Makefile: drop warning suppression on win build
    
    Commit dcdf71c21b99 ("- fix signed/unsigned build errors under
    win32. Thanks Zach Welch <zw...@su...>") in 2009 prevents
    gcc warnings on sign/unsigned comparisons while building for Win
    on folders 'helper' and 'server'.
    In 2011, commit b69119668ed8 ("RTOS Thread awareness support wip")
    uses the same method on the new folder 'rtos'.
    
    In mean time, all the incorrect sign/unsigned comparisons has been
    fixed and no warning is present with the default -Wextra flag that
    implies -Wsign-compare.
    The comment:
            # FD_* macros are sloppy with their signs on MinGW32 platform
    seems linked to some old implementation of MinGW32 include file
    that doesn't apply on current versions.
    
    Remove the obsolete hacks to suppress the warnings.
    
    Change-Id: I76dba9e54a647d3b9fbf1b7e9ae1844e3d7adc9a
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Reviewed-on: https://review.openocd.org/c/openocd/+/6254
    Tested-by: jenkins
    Reviewed-by: Xiaofan Chen <xia...@gm...>

diff --git a/src/helper/Makefile.am b/src/helper/Makefile.am
index 0d886843c..c1aeebf00 100644
--- a/src/helper/Makefile.am
+++ b/src/helper/Makefile.am
@@ -30,12 +30,6 @@ noinst_LTLIBRARIES += %D%/libhelper.la
 	%D%/jep106.inc \
 	%D%/jim-nvp.h
 
-%C%_libhelper_la_CFLAGS = $(AM_CFLAGS)
-if IS_MINGW
-# FD_* macros are sloppy with their signs on MinGW32 platform
-%C%_libhelper_la_CFLAGS += -Wno-sign-compare
-endif
-
 STARTUP_TCL_SRCS += %D%/startup.tcl
 EXTRA_DIST += \
 	%D%/bin2char.sh \
diff --git a/src/rtos/Makefile.am b/src/rtos/Makefile.am
index 49cb830e5..f09ac21a2 100644
--- a/src/rtos/Makefile.am
+++ b/src/rtos/Makefile.am
@@ -31,10 +31,3 @@ noinst_LTLIBRARIES += %D%/librtos.la
 	%D%/rtos_riot_stackings.h \
 	%D%/rtos_ucos_iii_stackings.h \
 	%D%/nuttx_header.h
-
-%C%_librtos_la_CFLAGS = $(AM_CFLAGS)
-
-if IS_MINGW
-# FD_* macros are sloppy with their signs on MinGW32 platform
-%C%_librtos_la_CFLAGS += -Wno-sign-compare
-endif
diff --git a/src/server/Makefile.am b/src/server/Makefile.am
index 5f7469a84..fb5248bfd 100644
--- a/src/server/Makefile.am
+++ b/src/server/Makefile.am
@@ -14,10 +14,4 @@ noinst_LTLIBRARIES += %D%/libserver.la
 	%D%/ipdbg.c \
 	%D%/ipdbg.h
 
-%C%_libserver_la_CFLAGS = $(AM_CFLAGS)
-if IS_MINGW
-# FD_* macros are sloppy with their signs on MinGW32 platform
-%C%_libserver_la_CFLAGS += -Wno-sign-compare
-endif
-
 STARTUP_TCL_SRCS += %D%/startup.tcl

-----------------------------------------------------------------------

Summary of changes:
 src/helper/Makefile.am | 6 ------
 src/rtos/Makefile.am   | 7 -------
 src/server/Makefile.am | 6 ------
 3 files changed, 19 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository