[OpenOCD-devel] [PATCH]: e48ea26 mips_mips64: fix minor host endianness bug

[<ge...@op...>]

This is an automated email from Gerrit.

Antonio Borneo (bor...@gm...) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/5944

-- gerrit

commit e48ea2690627b5e824feb6a15c98ab35ff486c71
Author: Antonio Borneo <bor...@gm...>
Date:   Sun Nov 22 13:02:32 2020 +0100

    mips_mips64: fix minor host endianness bug
    
    Commit 80f1a92bd798 ("mips64: Add generic mips64 target support")
    adds a log of the target's program counter in function
    mips_mips64_debug_entry() by directly casting the little-endian
    buffer in pc->value.
    This is going to print an incorrect value on big-endian hosts.
    
    Use the function buf_get_u64() to return the register value.
    
    Not tested on real HW. Issue identified with GCC compiler flag
    '-Wcast-align=strict' after change http://openocd.zylin.com/5937/
    ("target/register: use an array of uint8_t for register's value").
    
    Change-Id: Icbda2b54a03fdec287c804e623f5db4252f9cd2a
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Fixes: 80f1a92bd798 ("mips64: Add generic mips64 target support")

diff --git a/src/target/mips_mips64.c b/src/target/mips_mips64.c
index f941af5..0fc0897 100644
--- a/src/target/mips_mips64.c
+++ b/src/target/mips_mips64.c
@@ -62,7 +62,7 @@ static int mips_mips64_debug_entry(struct target *target)
 	mips_mips64_examine_debug_reason(target);
 
 	LOG_DEBUG("entered debug state at PC 0x%" PRIx64 ", target->state: %s",
-		  *(uint64_t *)pc->value, target_state_name(target));
+		  buf_get_u64(pc->value, 0, 64), target_state_name(target));
 
 	return ERROR_OK;
 }

--