From: OpenOCD-Gerrit <ope...@us...> - 2020-09-05 17:12:58
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Main OpenOCD repository". The branch, master has been updated via a098a14eb53131871469a9c32b206b0dc55ef237 (commit) from f788949651ef714024a29b08f4b064e78c9b4791 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a098a14eb53131871469a9c32b206b0dc55ef237 Author: Stafford Horne <sh...@gm...> Date: Wed Apr 5 06:11:30 2017 +0900 openrisc: Fix segv jsp due to free of unallocated data The prompt pointer in the jtag serial port is never zero'd or allocated. Completely remove it since there is not much use for it as the target software will provide the actual prompt. Change-Id: Id95d8ccb9f725e53b9d03386b11d91eba1cd6ef4 Signed-off-by: Stafford Horne <sh...@gm...> Reviewed-on: http://openocd.zylin.com/4093 Tested-by: jenkins Reviewed-by: Antonio Borneo <bor...@gm...> diff --git a/src/target/openrisc/jsp_server.c b/src/target/openrisc/jsp_server.c index 6fb764a6c..f28815df9 100644 --- a/src/target/openrisc/jsp_server.c +++ b/src/target/openrisc/jsp_server.c @@ -184,14 +184,8 @@ static int jsp_input(struct connection *connection) static int jsp_connection_closed(struct connection *connection) { - struct telnet_connection *t_con = connection->priv; struct jsp_service *jsp_service = connection->service->priv; - if (t_con->prompt) { - free(t_con->prompt); - t_con->prompt = NULL; - } - int retval = target_unregister_timer_callback(&jsp_poll_read, jsp_service); if (ERROR_OK != retval) return retval; ----------------------------------------------------------------------- Summary of changes: src/target/openrisc/jsp_server.c | 6 ------ 1 file changed, 6 deletions(-) hooks/post-receive -- Main OpenOCD repository |