[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.10.0-1234-g3474aa223

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  3474aa223a712ac848a8a8e58633106477db0641 (commit)
       via  185834ef8aa663faf6761e5c3d7c4a049c88eeab (commit)
      from  4f459660a9dab3877f6f27127e565dd2b49b4ec7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3474aa223a712ac848a8a8e58633106477db0641
Author: Antonio Borneo <bor...@gm...>
Date:   Mon May 6 12:31:57 2019 +0200

    coding style: prototype of functions with no parameters
    
    Functions that have no parameters should use "void" as parameter
    in the function declaration.
    
    Issue identified and fixed by script checkpatch from Linux kernel
    v5.1 using the command
    
            find src/ -type f -exec ./tools/scripts/checkpatch.pl \
            -q --types FUNCTION_WITHOUT_ARGS --fix-inplace -f {} \;
    
    Change-Id: If104ac75b44e939ec86155ff7b5720f2e33c6b39
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Reviewed-on: http://openocd.zylin.com/5621
    Reviewed-by: Andreas Fritiofson <and...@gm...>
    Tested-by: jenkins

diff --git a/src/helper/log.c b/src/helper/log.c
index ae26df5a1..380f548f4 100644
--- a/src/helper/log.c
+++ b/src/helper/log.c
@@ -401,7 +401,7 @@ char *alloc_printf(const char *format, ...)
  * fast when invoked more often than every 500ms.
  *
  */
-void keep_alive()
+void keep_alive(void)
 {
 	current_time = timeval_ms();
 	if (current_time-last_time > 1000) {
@@ -436,7 +436,7 @@ void keep_alive()
 }
 
 /* reset keep alive timer without sending message */
-void kept_alive()
+void kept_alive(void)
 {
 	current_time = timeval_ms();
 	last_time = current_time;
diff --git a/src/jtag/core.c b/src/jtag/core.c
index f12ab5924..884a74365 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -1872,7 +1872,7 @@ void jtag_set_verify(bool enable)
 	jtag_verify = enable;
 }
 
-bool jtag_will_verify()
+bool jtag_will_verify(void)
 {
 	return jtag_verify;
 }
@@ -1882,7 +1882,7 @@ void jtag_set_verify_capture_ir(bool enable)
 	jtag_verify_capture_ir = enable;
 }
 
-bool jtag_will_verify_capture_ir()
+bool jtag_will_verify_capture_ir(void)
 {
 	return jtag_verify_capture_ir;
 }
diff --git a/src/jtag/drivers/arm-jtag-ew.c b/src/jtag/drivers/arm-jtag-ew.c
index d35e15128..405278b9a 100644
--- a/src/jtag/drivers/arm-jtag-ew.c
+++ b/src/jtag/drivers/arm-jtag-ew.c
@@ -683,7 +683,7 @@ static int armjtagew_tap_execute(void)
 /****************************************************************************
  * JLink USB low-level functions */
 
-static struct armjtagew *armjtagew_usb_open()
+static struct armjtagew *armjtagew_usb_open(void)
 {
 	usb_init();
 
diff --git a/src/jtag/interface.c b/src/jtag/interface.c
index de132bbe8..56bbf6e51 100644
--- a/src/jtag/interface.c
+++ b/src/jtag/interface.c
@@ -45,7 +45,7 @@ void tap_set_state_impl(tap_state_t new_state)
 	state_follower = new_state;
 }
 
-tap_state_t tap_get_state()
+tap_state_t tap_get_state(void)
 {
 	return state_follower;
 }
@@ -64,7 +64,7 @@ void tap_set_end_state(tap_state_t new_end_state)
 	end_state_follower = new_end_state;
 }
 
-tap_state_t tap_get_end_state()
+tap_state_t tap_get_end_state(void)
 {
 	return end_state_follower;
 }
diff --git a/src/jtag/minidummy/minidummy.c b/src/jtag/minidummy/minidummy.c
index 7d5e6a98a..7ee206732 100644
--- a/src/jtag/minidummy/minidummy.c
+++ b/src/jtag/minidummy/minidummy.c
@@ -83,7 +83,7 @@ int interface_jtag_add_plain_dr_scan(int num_bits, const uint8_t *out_bits,
 	return ERROR_OK;
 }
 
-int interface_jtag_add_tlr()
+int interface_jtag_add_tlr(void)
 {
 	/* synchronously do the operation here */
 
diff --git a/src/jtag/zy1000/zy1000.c b/src/jtag/zy1000/zy1000.c
index 48a3d4d03..37af2f7ae 100644
--- a/src/jtag/zy1000/zy1000.c
+++ b/src/jtag/zy1000/zy1000.c
@@ -486,7 +486,7 @@ int interface_jtag_add_plain_dr_scan(int num_bits,
 	return ERROR_OK;
 }
 
-int interface_jtag_add_tlr()
+int interface_jtag_add_tlr(void)
 {
 	setCurrentState(TAP_RESET);
 	return ERROR_OK;

commit 185834ef8aa663faf6761e5c3d7c4a049c88eeab
Author: Antonio Borneo <bor...@gm...>
Date:   Mon May 6 12:18:30 2019 +0200

    coding style: add missing space when split strings
    
    Long strings are split across few lines; usually split occurs at
    the white space between two words.
    Check that the space between the two words is still present.
    While there, adjust the amount of space between words.
    
    Issue identified by checkpatch script from Linux kernel v5.1 using
    the command
    
            find src/ -type f -exec ./tools/scripts/checkpatch.pl \
            -q --types MISSING_SPACE -f {} \;
    
    Change-Id: I28b9a65564195ba967051add53d1c848c7b8fb30
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Reviewed-on: http://openocd.zylin.com/5620
    Reviewed-by: Andreas Fritiofson <and...@gm...>
    Tested-by: jenkins

diff --git a/src/flash/nor/at91sam3.c b/src/flash/nor/at91sam3.c
index b51e0972a..c9ffa653b 100644
--- a/src/flash/nor/at91sam3.c
+++ b/src/flash/nor/at91sam3.c
@@ -3726,7 +3726,7 @@ static const struct command_registration at91sam3_exec_command_handlers[] = {
 		.name = "info",
 		.handler = sam3_handle_info_command,
 		.mode = COMMAND_EXEC,
-		.help = "Print information about the current at91sam3 chip"
+		.help = "Print information about the current at91sam3 chip "
 			"and its flash configuration.",
 		.usage = "",
 	},
diff --git a/src/flash/nor/at91sam4.c b/src/flash/nor/at91sam4.c
index 135fc99bf..5b56c4241 100644
--- a/src/flash/nor/at91sam4.c
+++ b/src/flash/nor/at91sam4.c
@@ -3206,7 +3206,7 @@ static const struct command_registration at91sam4_exec_command_handlers[] = {
 		.name = "info",
 		.handler = sam4_handle_info_command,
 		.mode = COMMAND_EXEC,
-		.help = "Print information about the current at91sam4 chip"
+		.help = "Print information about the current at91sam4 chip "
 			"and its flash configuration.",
 		.usage = "",
 	},
diff --git a/src/helper/command.c b/src/helper/command.c
index 0882ecd58..4422b4abe 100644
--- a/src/helper/command.c
+++ b/src/helper/command.c
@@ -1219,9 +1219,9 @@ static const struct command_registration command_subcommand_handlers[] = {
 		.mode = COMMAND_ANY,
 		.jim_handler = jim_command_mode,
 		.usage = "[command_name ...]",
-		.help = "Returns the command modes allowed by a  command:"
-			"'any', 'config', or 'exec'.  If no command is"
-			"specified, returns the current command mode.  "
+		.help = "Returns the command modes allowed by a command: "
+			"'any', 'config', or 'exec'. If no command is "
+			"specified, returns the current command mode. "
 			"Returns 'unknown' if an unknown command is given. "
 			"Command can be multiple tokens.",
 	},
diff --git a/src/rtos/ChibiOS.c b/src/rtos/ChibiOS.c
index 8839acc9a..08b234fa9 100644
--- a/src/rtos/ChibiOS.c
+++ b/src/rtos/ChibiOS.c
@@ -200,7 +200,7 @@ static int ChibiOS_update_memory_signature(struct rtos *rtos)
 	/* Currently, we have the inherent assumption that all address pointers
 	 * are 32 bit wide. */
 	if (signature->ch_ptrsize != sizeof(uint32_t)) {
-		LOG_ERROR("ChibiOS/RT target memory signature claims an address"
+		LOG_ERROR("ChibiOS/RT target memory signature claims an address "
 				  "width unequal to 32 bits!");
 		free(signature);
 		return -1;
diff --git a/src/rtos/linux.c b/src/rtos/linux.c
index 0f18d171c..e85a3bdf8 100644
--- a/src/rtos/linux.c
+++ b/src/rtos/linux.c
@@ -1379,8 +1379,8 @@ static int linux_thread_packet(struct connection *connection, char const *packet
 						 target->rtos->
 						 current_threadid)
 				&& (target->rtos->current_threadid != -1))
-					LOG_WARNING("WARNING! current GDB thread do not match"
-							"current thread running."
+					LOG_WARNING("WARNING! current GDB thread do not match "
+							"current thread running. "
 							"Switch thread in GDB to threadid %d",
 							(int)ct->threadid);
 
diff --git a/src/target/nds32_cmd.c b/src/target/nds32_cmd.c
index 7bf7e60c7..d7d040e4b 100644
--- a/src/target/nds32_cmd.c
+++ b/src/target/nds32_cmd.c
@@ -1007,7 +1007,7 @@ static const struct command_registration nds32_exec_command_handlers[] = {
 		.handler = handle_nds32_global_stop_command,
 		.mode = COMMAND_ANY,
 		.usage = "['on'|'off']",
-		.help = "turn on/off global stop. After turning on, every load/store"
+		.help = "turn on/off global stop. After turning on, every load/store "
 			 "instructions will be stopped to check memory access.",
 	},
 	{
diff --git a/src/target/riscv/riscv.c b/src/target/riscv/riscv.c
index 7ad1ccde9..b5fd22b48 100644
--- a/src/target/riscv/riscv.c
+++ b/src/target/riscv/riscv.c
@@ -1858,13 +1858,13 @@ static const struct command_registration riscv_exec_command_handlers[] = {
 		.name = "test_sba_config_reg",
 		.handler = riscv_test_sba_config_reg,
 		.mode = COMMAND_ANY,
-		.usage = "riscv test_sba_config_reg legal_address num_words"
+		.usage = "riscv test_sba_config_reg legal_address num_words "
 			"illegal_address run_sbbusyerror_test[on/off]",
-		.help = "Perform a series of tests on the SBCS register."
-			"Inputs are a legal, 128-byte aligned address and a number of words to"
-			"read/write starting at that address (i.e., address range [legal address,"
-			"legal_address+word_size*num_words) must be legally readable/writable)"
-			", an illegal, 128-byte aligned address for error flag/handling cases,"
+		.help = "Perform a series of tests on the SBCS register. "
+			"Inputs are a legal, 128-byte aligned address and a number of words to "
+			"read/write starting at that address (i.e., address range [legal address, "
+			"legal_address+word_size*num_words) must be legally readable/writable), "
+			"an illegal, 128-byte aligned address for error flag/handling cases, "
 			"and whether sbbusyerror test should be run."
 	},
 	{
diff --git a/src/target/target.c b/src/target/target.c
index 538831b5b..b0deadb0b 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -6232,7 +6232,7 @@ static const struct command_registration target_exec_command_handlers[] = {
 		.name = "halt",
 		.handler = handle_halt_command,
 		.mode = COMMAND_EXEC,
-		.help = "request target to halt, then wait up to the specified"
+		.help = "request target to halt, then wait up to the specified "
 			"number of milliseconds (default 5000) for it to complete",
 		.usage = "[milliseconds]",
 	},
@@ -6248,7 +6248,7 @@ static const struct command_registration target_exec_command_handlers[] = {
 		.handler = handle_reset_command,
 		.mode = COMMAND_EXEC,
 		.usage = "[run|halt|init]",
-		.help = "Reset all targets into the specified mode."
+		.help = "Reset all targets into the specified mode. "
 			"Default reset mode is run, if not given.",
 	},
 	{

-----------------------------------------------------------------------

Summary of changes:
 src/flash/nor/at91sam3.c       |  2 +-
 src/flash/nor/at91sam4.c       |  2 +-
 src/helper/command.c           |  6 +++---
 src/helper/log.c               |  4 ++--
 src/jtag/core.c                |  4 ++--
 src/jtag/drivers/arm-jtag-ew.c |  2 +-
 src/jtag/interface.c           |  4 ++--
 src/jtag/minidummy/minidummy.c |  2 +-
 src/jtag/zy1000/zy1000.c       |  2 +-
 src/rtos/ChibiOS.c             |  2 +-
 src/rtos/linux.c               |  4 ++--
 src/target/nds32_cmd.c         |  2 +-
 src/target/riscv/riscv.c       | 12 ++++++------
 src/target/target.c            |  4 ++--
 14 files changed, 26 insertions(+), 26 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository




[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.10.0-1234-g3474aa223

The Open On-Chip Debugger

[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.10.0-1234-g3474aa223