[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.10.0-1187-g6dcd255b7

[OpenOCD-Gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  6dcd255b7bde5d7d3a8805c3a0e81f5edf42ccf4 (commit)
      from  c0644401622d1d5bf42e522452c7c9f83293cfd8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6dcd255b7bde5d7d3a8805c3a0e81f5edf42ccf4
Author: Tomas Vanek <va...@fb...>
Date:   Fri Mar 13 15:13:21 2020 +0100

    jtag/drivers/ulink: fix clang static analyzer warning
    
    scan-build-9:
    Description: Access to field 'payload_in' results in a dereference
     of a null pointer (loaded from field 'queue_start')
    File: src/jtag/drivers/ulink.c
    Line: 2216
    
    Set input/output_signals conditionally if ulink_append_get_signals_cmd()
    and ulink_execute_queued_commands() returns no error.
    Do not fail driver initialisation as the signals are only printed.
    
    Change-Id: I6c842f0e9a604712abf7444a2fa95ba5810de1ff
    Signed-off-by: Tomas Vanek <va...@fb...>
    Reviewed-on: http://openocd.zylin.com/5520
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <bor...@gm...>
    Reviewed-by: Oleksij Rempel <li...@re...>

diff --git a/src/jtag/drivers/ulink.c b/src/jtag/drivers/ulink.c
index 9235eb893..4066d6109 100644
--- a/src/jtag/drivers/ulink.c
+++ b/src/jtag/drivers/ulink.c
@@ -2210,14 +2210,17 @@ static int ulink_init(void)
 	}
 	ulink_clear_queue(ulink_handle);
 
-	ulink_append_get_signals_cmd(ulink_handle);
-	ulink_execute_queued_commands(ulink_handle, 200);
+	ret = ulink_append_get_signals_cmd(ulink_handle);
+	if (ret == ERROR_OK)
+		ret = ulink_execute_queued_commands(ulink_handle, 200);
 
-	/* Post-process the single CMD_GET_SIGNALS command */
-	input_signals = ulink_handle->queue_start->payload_in[0];
-	output_signals = ulink_handle->queue_start->payload_in[1];
+	if (ret == ERROR_OK) {
+		/* Post-process the single CMD_GET_SIGNALS command */
+		input_signals = ulink_handle->queue_start->payload_in[0];
+		output_signals = ulink_handle->queue_start->payload_in[1];
 
-	ulink_print_signal_states(input_signals, output_signals);
+		ulink_print_signal_states(input_signals, output_signals);
+	}
 
 	ulink_clear_queue(ulink_handle);
 

-----------------------------------------------------------------------

Summary of changes:
 src/jtag/drivers/ulink.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository