[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.10.0-1125-g2e1dfebc8

[OpenOCD-Gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  2e1dfebc8e62376e0ae3e55ac776149bed462330 (commit)
       via  939febeccafc885d3869ce94c688aaf724f2eccd (commit)
      from  44967a9e07ff01a01a96757f302c053553cff35e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2e1dfebc8e62376e0ae3e55ac776149bed462330
Author: Antonio Borneo <bor...@gm...>
Date:   Sat Oct 19 19:46:53 2019 +0200

    jimtcl: update to tag 0.79
    
    OpenOCD is stuck at jimtcl tag 0.77 that is 3 years old.
    The latest tag 0.79 (2019-11-20) is already used by debian build,
    which packs jim library separately, as shown in [1]. Today only
    the build for architecture powerpcspe is still not updated to
    latest package version.
    I have been using jim 0.79 since the day of the release, without
    any issue.
    
    Switch jimtcl to latest tag 0.79
    
    [1] https://packages.debian.org/sid/openocd
    
    Change-Id: I3426e68c32f88ecde74d4278303925423db451e0
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Reviewed-on: http://openocd.zylin.com/5403
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <va...@fb...>

diff --git a/jimtcl b/jimtcl
index a9bf5975f..0aa0fb4e3 160000
--- a/jimtcl
+++ b/jimtcl
@@ -1 +1 @@
-Subproject commit a9bf5975fd0f89974d689a2d9ebd0873c8d64787
+Subproject commit 0aa0fb4e3a38d38a49de9eb585d93d63a370dcf6

commit 939febeccafc885d3869ce94c688aaf724f2eccd
Author: Antonio Borneo <bor...@gm...>
Date:   Fri Feb 14 14:35:51 2020 +0100

    target: fix crash with jimtcl 0.78
    
    The jimtcl commit 41c5ff1809f5 ("jim.c: Fix Object leak in zlib
    support") https://repo.or.cz/jimtcl.git/commit/41c5ff1809f5
    makes Jim_SetResultFormatted() freeing the parameters that have
    zero refcount.
    
    OpenOCD commit 559d08c19ed8 ("jim tests: use installed") adds the
    only code instance in OpenOCD that first passes a zero refcount
    object to Jim_SetResultFormatted() and then frees it.
    By switching jimtcl version to 0.78 or newer this causes a crash
    of OpenOCD.
    To trigger the crash in a telnet session, check that the current
    target is running and type:
            [target current] arp_waitstate halted 1
    
    Remove the call to Jim_FreeNewObj() after the call to
    Jim_SetResultFormatted().
    
    Change-Id: I5f5a8bca96a0e8466ff7b789fe578ea9785fa550
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Reviewed-on: http://openocd.zylin.com/5453
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <va...@fb...>

diff --git a/src/target/target.c b/src/target/target.c
index 61ed9662d..ceecaee10 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -5164,7 +5164,6 @@ static int jim_target_wait_state(Jim_Interp *interp, int argc, Jim_Obj *const *a
 				"target: %s wait %s fails (%#s) %s",
 				target_name(target), n->name,
 				eObj, target_strerror_safe(e));
-		Jim_FreeNewObj(interp, eObj);
 		return JIM_ERR;
 	}
 	return JIM_OK;

-----------------------------------------------------------------------

Summary of changes:
 jimtcl              | 2 +-
 src/target/target.c | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository