[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.10.0-1108-g4e981bc27

[OpenOCD-Gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  4e981bc27c36e696dc8ace3ab4bab534564770c1 (commit)
       via  2ebedbdf383601104ed441dda19e107a76cdf248 (commit)
      from  b07604cc6aacc5591afd281e0d65ab27280f19b4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4e981bc27c36e696dc8ace3ab4bab534564770c1
Author: Tomas Vanek <va...@fb...>
Date:   Fri Dec 20 23:43:13 2019 +0100

    target/arm920t: fix clang static analyzer warning
    
    Change-Id: I570dfb8b20a3f187f1fe660343cf0b75691e2c30
    Signed-off-by: Tomas Vanek <va...@fb...>
    Reviewed-on: http://openocd.zylin.com/5375
    Tested-by: jenkins
    Reviewed-by: Oleksij Rempel <li...@re...>

diff --git a/src/target/arm920t.c b/src/target/arm920t.c
index 2ecf218fd..3ddd19888 100644
--- a/src/target/arm920t.c
+++ b/src/target/arm920t.c
@@ -484,7 +484,7 @@ int arm920t_post_debug_entry(struct target *target)
 /* EXPORTED to FA256 */
 void arm920t_pre_restore_context(struct target *target)
 {
-	uint32_t cp15c15;
+	uint32_t cp15c15 = 0;
 	struct arm920t_common *arm920t = target_to_arm920(target);
 
 	/* restore i/d fault status and address register */

commit 2ebedbdf383601104ed441dda19e107a76cdf248
Author: Tomas Vanek <va...@fb...>
Date:   Fri Dec 20 23:35:12 2019 +0100

    rtos/linux: fix use of memory after it is freed
    
    Discovered by clang static analyzer
    
    Change-Id: I9f64a67f281b95562d8fd6e2ebb0ae3f79ae8039
    Signed-off-by: Tomas Vanek <va...@fb...>
    Reviewed-on: http://openocd.zylin.com/5371
    Tested-by: jenkins
    Reviewed-by: Oleksij Rempel <li...@re...>

diff --git a/src/rtos/linux.c b/src/rtos/linux.c
index 74172b70a..9e59c41a5 100644
--- a/src/rtos/linux.c
+++ b/src/rtos/linux.c
@@ -621,17 +621,17 @@ struct threads *liste_del_task(struct threads *task_list, struct threads **t,
 	struct threads *prev)
 {
 	LOG_INFO("del task %" PRId64, (*t)->threadid);
-	prev->next = (*t)->next;
-
-	if (prev == task_list)
-		task_list = prev;
+	if (prev)
+		prev->next = (*t)->next;
+	else
+		task_list = (*t)->next;
 
 	/*  free content of threads */
 	if ((*t)->context)
 		free((*t)->context);
 
 	free(*t);
-	*t = prev;
+	*t = prev ? prev : task_list;
 	return task_list;
 }
 
@@ -725,6 +725,7 @@ int linux_get_tasks(struct target *target, int context)
 
 		/*  check that this thread is not one the current threads already
 		 *  created */
+		uint32_t base_addr;
 #ifdef PID_CHECK
 
 		if (!current_pid(linux_os, t->pid)) {
@@ -745,12 +746,13 @@ int linux_get_tasks(struct target *target, int context)
 				t->context =
 					cpu_context_read(target, t->base_addr,
 						&t->thread_info_addr);
+			base_addr = next_task(target, t);
 		} else {
 			/*LOG_INFO("thread %s is a current thread already created",t->name); */
+			base_addr = next_task(target, t);
 			free(t);
 		}
 
-		uint32_t base_addr = next_task(target, t);
 		t = calloc(1, sizeof(struct threads));
 		t->base_addr = base_addr;
 	}
@@ -1178,7 +1180,7 @@ int linux_gdb_T_packet(struct connection *connection,
 
 	if (linux_os->threads_needs_update == 0) {
 		struct threads *temp = linux_os->thread_list;
-		struct threads *prev = linux_os->thread_list;
+		struct threads *prev = NULL;
 
 		while (temp != NULL) {
 			if (temp->threadid == threadid) {

-----------------------------------------------------------------------

Summary of changes:
 src/rtos/linux.c     | 16 +++++++++-------
 src/target/arm920t.c |  2 +-
 2 files changed, 10 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository