From: Øyvind H. <go...@us...> - 2010-06-07 15:10:30
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Main OpenOCD repository". The branch, master has been updated via 00635e28ba5c405742cae261d8551f165dc78ba3 (commit) from a1cf1b52444c67b6c56ad58fe29be5a285b244cb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 00635e28ba5c405742cae261d8551f165dc78ba3 Author: Ãyvind Harboe <oyv...@zy...> Date: Sat Jun 5 11:30:49 2010 +0200 jtag: rename JTAG_MOVESTATE to JTAG_TLR_RESET JTAG_MOVESTATE is misleading, this cmd is only used for reset. JTAG_PATHMOVE should be used otherwise. Signed-off-by: Ãyvind Harboe <oyv...@zy...> diff --git a/src/jtag/commands.h b/src/jtag/commands.h index 87bd9c5..d591814 100644 --- a/src/jtag/commands.h +++ b/src/jtag/commands.h @@ -139,7 +139,14 @@ union jtag_command_container { */ enum jtag_command_type { JTAG_SCAN = 1, - JTAG_STATEMOVE = 2, + /* JTAG_TLR_RESET's non-minidriver implementation is a + * vestige from a statemove cmd. The statemove command + * is obsolete and replaced by pathmove. + * + * pathmove does not support reset as one of it's states, + * hence the need for an explicit statemove command. + */ + JTAG_TLR_RESET = 2, JTAG_RUNTEST = 3, JTAG_RESET = 4, JTAG_PATHMOVE = 6, diff --git a/src/jtag/drivers/amt_jtagaccel.c b/src/jtag/drivers/amt_jtagaccel.c index 121649b..fca8cfe 100644 --- a/src/jtag/drivers/amt_jtagaccel.c +++ b/src/jtag/drivers/amt_jtagaccel.c @@ -356,7 +356,7 @@ static int amt_jtagaccel_execute_queue(void) amt_jtagaccel_end_state(cmd->cmd.runtest->end_state); amt_jtagaccel_runtest(cmd->cmd.runtest->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("statemove end in %i", cmd->cmd.statemove->end_state); #endif diff --git a/src/jtag/drivers/arm-jtag-ew.c b/src/jtag/drivers/arm-jtag-ew.c index e54c8c6..9d8b8b1 100644 --- a/src/jtag/drivers/arm-jtag-ew.c +++ b/src/jtag/drivers/arm-jtag-ew.c @@ -117,7 +117,7 @@ static int armjtagew_execute_queue(void) armjtagew_runtest(cmd->cmd.runtest->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: DEBUG_JTAG_IO("statemove end in %i", cmd->cmd.statemove->end_state); armjtagew_end_state(cmd->cmd.statemove->end_state); diff --git a/src/jtag/drivers/bitbang.c b/src/jtag/drivers/bitbang.c index 6159ef7..4548cb5 100644 --- a/src/jtag/drivers/bitbang.c +++ b/src/jtag/drivers/bitbang.c @@ -304,7 +304,7 @@ int bitbang_execute_queue(void) bitbang_stableclocks(cmd->cmd.stableclocks->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("statemove end in %s", tap_state_name(cmd->cmd.statemove->end_state)); #endif diff --git a/src/jtag/drivers/bitq.c b/src/jtag/drivers/bitq.c index 79ca349..a58f633 100644 --- a/src/jtag/drivers/bitq.c +++ b/src/jtag/drivers/bitq.c @@ -323,7 +323,7 @@ int bitq_execute_queue(void) bitq_runtest(cmd->cmd.runtest->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("statemove end in %i", cmd->cmd.statemove->end_state); #endif diff --git a/src/jtag/drivers/buspirate.c b/src/jtag/drivers/buspirate.c index 99210d2..1c433a9 100644 --- a/src/jtag/drivers/buspirate.c +++ b/src/jtag/drivers/buspirate.c @@ -146,7 +146,7 @@ static int buspirate_execute_queue(void) buspirate_runtest(cmd->cmd.runtest ->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: DEBUG_JTAG_IO("statemove end in %s", tap_state_name(cmd->cmd.statemove ->end_state)); diff --git a/src/jtag/drivers/driver.c b/src/jtag/drivers/driver.c index 7f7f879..49f4024 100644 --- a/src/jtag/drivers/driver.c +++ b/src/jtag/drivers/driver.c @@ -338,7 +338,7 @@ int interface_jtag_add_tlr(void) jtag_queue_command(cmd); - cmd->type = JTAG_STATEMOVE; + cmd->type = JTAG_TLR_RESET; cmd->cmd.statemove = cmd_queue_alloc(sizeof(struct statemove_command)); cmd->cmd.statemove->end_state = state; diff --git a/src/jtag/drivers/ft2232.c b/src/jtag/drivers/ft2232.c index 93d1c4a..2ac410a 100644 --- a/src/jtag/drivers/ft2232.c +++ b/src/jtag/drivers/ft2232.c @@ -1978,7 +1978,7 @@ static int ft2232_execute_command(struct jtag_command *cmd) { case JTAG_RESET: retval = ft2232_execute_reset(cmd); break; case JTAG_RUNTEST: retval = ft2232_execute_runtest(cmd); break; - case JTAG_STATEMOVE: retval = ft2232_execute_statemove(cmd); break; + case JTAG_TLR_RESET: retval = ft2232_execute_statemove(cmd); break; case JTAG_PATHMOVE: retval = ft2232_execute_pathmove(cmd); break; case JTAG_SCAN: retval = ft2232_execute_scan(cmd); break; case JTAG_SLEEP: retval = ft2232_execute_sleep(cmd); break; diff --git a/src/jtag/drivers/gw16012.c b/src/jtag/drivers/gw16012.c index 0e9f3fe..cb29d33 100644 --- a/src/jtag/drivers/gw16012.c +++ b/src/jtag/drivers/gw16012.c @@ -344,7 +344,7 @@ static int gw16012_execute_queue(void) gw16012_end_state(cmd->cmd.runtest->end_state); gw16012_runtest(cmd->cmd.runtest->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("statemove end in %i", cmd->cmd.statemove->end_state); #endif diff --git a/src/jtag/drivers/jlink.c b/src/jtag/drivers/jlink.c index 21dfab2..34fce38 100644 --- a/src/jtag/drivers/jlink.c +++ b/src/jtag/drivers/jlink.c @@ -202,7 +202,7 @@ static void jlink_execute_command(struct jtag_command *cmd) switch (cmd->type) { case JTAG_RUNTEST: jlink_execute_runtest(cmd); break; - case JTAG_STATEMOVE: jlink_execute_statemove(cmd); break; + case JTAG_TLR_RESET: jlink_execute_statemove(cmd); break; case JTAG_PATHMOVE: jlink_execute_pathmove(cmd); break; case JTAG_SCAN: jlink_execute_scan(cmd); break; case JTAG_RESET: jlink_execute_reset(cmd); break; diff --git a/src/jtag/drivers/rlink.c b/src/jtag/drivers/rlink.c index 43f1940..0060baf 100644 --- a/src/jtag/drivers/rlink.c +++ b/src/jtag/drivers/rlink.c @@ -1398,7 +1398,7 @@ int rlink_execute_queue(void) switch (cmd->type) { case JTAG_RUNTEST: - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: case JTAG_PATHMOVE: case JTAG_SCAN: break; @@ -1430,7 +1430,7 @@ int rlink_execute_queue(void) rlink_end_state(cmd->cmd.runtest->end_state); rlink_runtest(cmd->cmd.runtest->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("statemove end in %i", cmd->cmd.statemove->end_state); #endif diff --git a/src/jtag/drivers/usbprog.c b/src/jtag/drivers/usbprog.c index 0d51b27..cc78555 100644 --- a/src/jtag/drivers/usbprog.c +++ b/src/jtag/drivers/usbprog.c @@ -131,7 +131,7 @@ static int usbprog_execute_queue(void) usbprog_end_state(cmd->cmd.runtest->end_state); usbprog_runtest(cmd->cmd.runtest->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("statemove end in %i", cmd->cmd.statemove->end_state); #endif diff --git a/src/jtag/drivers/vsllink.c b/src/jtag/drivers/vsllink.c index a985677..450ce06 100644 --- a/src/jtag/drivers/vsllink.c +++ b/src/jtag/drivers/vsllink.c @@ -165,7 +165,7 @@ static int vsllink_execute_queue(void) vsllink_runtest(cmd->cmd.runtest->num_cycles); break; - case JTAG_STATEMOVE: + case JTAG_TLR_RESET: DEBUG_JTAG_IO("statemove end in %s", tap_state_name(cmd->cmd.statemove ->end_state)); ----------------------------------------------------------------------- Summary of changes: src/jtag/commands.h | 9 ++++++++- src/jtag/drivers/amt_jtagaccel.c | 2 +- src/jtag/drivers/arm-jtag-ew.c | 2 +- src/jtag/drivers/bitbang.c | 2 +- src/jtag/drivers/bitq.c | 2 +- src/jtag/drivers/buspirate.c | 2 +- src/jtag/drivers/driver.c | 2 +- src/jtag/drivers/ft2232.c | 2 +- src/jtag/drivers/gw16012.c | 2 +- src/jtag/drivers/jlink.c | 2 +- src/jtag/drivers/rlink.c | 4 ++-- src/jtag/drivers/usbprog.c | 2 +- src/jtag/drivers/vsllink.c | 2 +- 13 files changed, 21 insertions(+), 14 deletions(-) hooks/post-receive -- Main OpenOCD repository |