[openocd-svn] Main OpenOCD repository branch, master, updated. v0.4.0-249-g3ecc191

[Spencer O. <nt...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  3ecc191b361d913d3bdf156568454de57f093aee (commit)
      from  5fd1c2db9ad43cc893d6287549262f82e6932e90 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3ecc191b361d913d3bdf156568454de57f093aee
Author: Spencer Oliver <nt...@us...>
Date:   Mon May 17 10:17:21 2010 +0100

    gdbserver: gdb cmds returning failure on success
    
    The gdb_memory_map cmd for example fell through and returned
    ERROR_COMMAND_SYNTAX_ERROR on success - behaviour is now as expected.
    
    Signed-off-by: Spencer Oliver <nt...@us...>

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index 5b4fb7a..a84c618 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -2503,26 +2503,29 @@ COMMAND_HANDLER(handle_gdb_port_command)
 
 COMMAND_HANDLER(handle_gdb_memory_map_command)
 {
-	if (CMD_ARGC == 1)
-		COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_use_memory_map);
+	if (CMD_ARGC != 1)
+		return ERROR_COMMAND_SYNTAX_ERROR;
 
-	return ERROR_COMMAND_SYNTAX_ERROR;
+	COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_use_memory_map);
+	return ERROR_OK;
 }
 
 COMMAND_HANDLER(handle_gdb_flash_program_command)
 {
-	if (CMD_ARGC == 1)
-		COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_flash_program);
+	if (CMD_ARGC != 1)
+		return ERROR_COMMAND_SYNTAX_ERROR;
 
-	return ERROR_COMMAND_SYNTAX_ERROR;
+	COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_flash_program);
+	return ERROR_OK;
 }
 
 COMMAND_HANDLER(handle_gdb_report_data_abort_command)
 {
-	if (CMD_ARGC == 1)
-		COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_report_data_abort);
+	if (CMD_ARGC != 1)
+		return ERROR_COMMAND_SYNTAX_ERROR;
 
-	return ERROR_COMMAND_SYNTAX_ERROR;
+	COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_report_data_abort);
+	return ERROR_OK;
 }
 
 /* gdb_breakpoint_override */

-----------------------------------------------------------------------

Summary of changes:
 src/server/gdb_server.c |   21 ++++++++++++---------
 1 files changed, 12 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository