[openocd-svn] Main OpenOCD repository branch, master, updated. v0.4.0-124-gb7811b7

[Øyvind H. <go...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  b7811b76795aaeacfea0473bdca2c44826f20501 (commit)
      from  5dcad2d34fc40659018da2cf75ceeacd3abea860 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b7811b76795aaeacfea0473bdca2c44826f20501
Author: Øyvind Harboe <oyv...@zy...>
Date:   Sun Mar 21 19:20:26 2010 +0100

    arm breakpoints: amended fix comment
    
    the handling of caches, should be moved into the breakpoint
    specific callbacks rather than being plonked into generic
    memory write fn's.
    
    Signed-off-by: Øyvind Harboe <oyv...@zy...>

diff --git a/src/target/arm920t.c b/src/target/arm920t.c
index 4916de1..99f7dca 100644
--- a/src/target/arm920t.c
+++ b/src/target/arm920t.c
@@ -567,7 +567,11 @@ int arm920t_write_memory(struct target *target, uint32_t address,
 
 	/* FIX!!!! this should be cleaned up and made much more general. The
 	 * plan is to write up and test on arm920t specifically and
-	 * then generalize and clean up afterwards. */
+	 * then generalize and clean up afterwards.
+	 *
+	 * Also it should be moved to the callbacks that handle breakpoints
+	 * specifically and not the generic memory write fn's. See XScale code.
+	 */
 	if (arm920t->armv4_5_mmu.mmu_enabled && (count == 1) &&
 			((size==2) || (size==4)))
 	{
diff --git a/src/target/arm926ejs.c b/src/target/arm926ejs.c
index ff18bae..1f753a6 100644
--- a/src/target/arm926ejs.c
+++ b/src/target/arm926ejs.c
@@ -579,7 +579,12 @@ int arm926ejs_write_memory(struct target *target, uint32_t address,
 
 	/* FIX!!!! this should be cleaned up and made much more general. The
 	 * plan is to write up and test on arm926ejs specifically and
-	 * then generalize and clean up afterwards. */
+	 * then generalize and clean up afterwards.
+	 *
+	 *
+	 * Also it should be moved to the callbacks that handle breakpoints
+	 * specifically and not the generic memory write fn's. See XScale code.
+	 **/
 	if (arm926ejs->armv4_5_mmu.mmu_enabled && (count == 1) && ((size==2) || (size==4)))
 	{
 		/* special case the handling of single word writes to bypass MMU

-----------------------------------------------------------------------

Summary of changes:
 src/target/arm920t.c   |    6 +++++-
 src/target/arm926ejs.c |    7 ++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository