From: Øyvind H. <go...@us...> - 2010-02-09 21:58:13
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Main OpenOCD repository". The branch, master has been updated via c646b767971f5750b32f0bc8290a2eea351cb514 (commit) from f899c2aa9767ba7bf731e6c6c1af2c437af97dac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c646b767971f5750b32f0bc8290a2eea351cb514 Author: Ãyvind Harboe <oyv...@zy...> Date: Tue Feb 9 21:54:55 2010 +0100 target: add todo in target_write_memory() about alignment target_write_buffer() does not align "buffer" in host memory passed to target_write_memory(). Signed-off-by: Ãyvind Harboe <oyv...@zy...> diff --git a/src/target/target.h b/src/target/target.h index da91d46..7400b7e 100644 --- a/src/target/target.h +++ b/src/target/target.h @@ -2,7 +2,7 @@ * Copyright (C) 2005 by Dominic Rath * * Dom...@gm... * * * - * Copyright (C) 2007-9 Ãyvind Harboe * + * Copyright (C) 2007-2010 Ãyvind Harboe * * oyv...@zy... * * * * Copyright (C) 2008 by Spencer Oliver * @@ -371,7 +371,18 @@ int target_read_memory(struct target *target, uint32_t address, uint32_t size, uint32_t count, uint8_t *buffer); /** * Write @a count items of @a size bytes to the memory of @a target at - * the @a address given. + * the @a address given. @a address must be aligned to @a size + * in target memory. + * + * The endianness is the same in the host and target memory for this + * function. + * + * \todo TODO: + * Really @a buffer should have been defined as "const void *" and + * @a buffer should have been aligned to @a size in the host memory. + * + * This is not enforced via e.g. assert's today and e.g. the + * target_write_buffer fn breaks this assumption. * * This routine is wrapper for target->type->write_memory. */ ----------------------------------------------------------------------- Summary of changes: src/target/target.h | 15 +++++++++++++-- 1 files changed, 13 insertions(+), 2 deletions(-) hooks/post-receive -- Main OpenOCD repository |