From: oharboe at B. <oh...@ma...> - 2009-08-30 23:12:51
|
Author: oharboe Date: 2009-08-30 23:12:50 +0200 (Sun, 30 Aug 2009) New Revision: 2655 Modified: trunk/src/flash/davinci_nand.c Log: David Brownell <da...@pa...> Minor code bugfix: check right variable. Via code review by Steve Grubb <sg...@re...>?\194?\160 Almost innocuous; this is value is checked later, this check being wrong would make it check stack garbage. Modified: trunk/src/flash/davinci_nand.c =================================================================== --- trunk/src/flash/davinci_nand.c 2009-08-30 20:08:07 UTC (rev 2654) +++ trunk/src/flash/davinci_nand.c 2009-08-30 21:12:50 UTC (rev 2655) @@ -663,7 +663,7 @@ } aemif = strtoul(argv[4], &ep, 0); - if (*ep || chip == 0 || chip == ULONG_MAX) { + if (*ep || aemif == 0 || aemif == ULONG_MAX) { LOG_ERROR("Invalid AEMIF controller address %s", argv[4]); goto fail; } |