[Openocd-svn] r1663 - trunk/src/target

[oharboe at B. <oh...@ma...>]

Author: oharboe
Date: 2009-05-08 08:14:08 +0200 (Fri, 08 May 2009)
New Revision: 1663

Modified:
   trunk/src/target/arm7tdmi.c
   trunk/src/target/arm_adi_v5.c
Log:
added comments w.r.t. potential performance problems

Modified: trunk/src/target/arm7tdmi.c
===================================================================
--- trunk/src/target/arm7tdmi.c	2009-05-08 05:33:08 UTC (rev 1662)
+++ trunk/src/target/arm7tdmi.c	2009-05-08 06:14:08 UTC (rev 1663)
@@ -372,6 +372,13 @@
 	*pc -= 0xa;
 }
 
+
+/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
+ * roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
+ *
+ * The solution is to arrange for a large out/in scan in this loop and
+ * and convert data afterwards.
+ */
 void arm7tdmi_read_core_regs(target_t *target, u32 mask, u32* core_regs[16])
 {
 	int i;

Modified: trunk/src/target/arm_adi_v5.c
===================================================================
--- trunk/src/target/arm_adi_v5.c	2009-05-08 05:33:08 UTC (rev 1662)
+++ trunk/src/target/arm_adi_v5.c	2009-05-08 06:14:08 UTC (rev 1663)
@@ -867,6 +867,12 @@
 	return retval;
 }
 
+/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
+ * roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
+ *
+ * The solution is to arrange for a large out/in scan in this loop and
+ * and convert data afterwards.
+ */
 int mem_ap_read_buf_packed_u8(swjdp_common_t *swjdp, u8 *buffer, int count, u32 address)
 {
 	u32 invalue;