Re: [openobex-users] netbuf patch - updated

[Marcel H. <ma...@ho...>]

Hi Alex,

> > The slist_remove() should do "if (!list) return NULL". This save an
> > indentation and make it more readable.
> >
> > In buf_new() the label is not needed. It is fine to use "return NULL" in
> > both cases.
> >
> > The buf_total_size() missed a check for p.
> >
> > In buf_resize() we can use direkt return instead of the label. For
> > exmaple "if (!p) return".
> >
> > For buf_reuse() and buf_free() use "if (!p) return".
> >
> > And of course all "} else {" must be on the same line.
> 
> Here's the fixed version.

it needs some additional empty lines to make it more readable, but I
will do that by myself after I applied it. Otherwise it looks good to
me. Any additional comments?

Regards

Marcel