From: Eduardo P. H. <eha...@ra...> - 2006-01-19 13:09:23
|
On Thu, Jan 19, 2006 at 01:39:12PM +0100, Marcel Holtmann wrote: > Hi Eduardo, >=20 Hi, (sorry for being too verbose :) <snip> >=20 > > Otherwise, if libusb without libusb.pc is supposed to be supported, > > the generation of a broken openobex.pc in this case seems to need a fix. >=20 > No. The libusb needs to be fixed, because it is their bug not to install > a libusb.pc file. The only other option is not to install the openobex > pkgconfig file at all. If not having pkg-config support is a bug on libusb, having a broken openobex.pc file seems to be a worse bug to me. But it is just my personal point of view. >=20 > > The current case seems a bit inconsistent to me: libusbwithout libusb.pc > > is supported at build time, but it generates an openobex install that > > isn't working completely ('pkg-config --cflags' openobex isn't working). >=20 > Maybe from pkgconfig people, but people that detect openobex by themself > and others that use openobex.m4 it would be bad to not include libusb > support only because of a missing libusb.pc file. I think I got your point: currently a missing libusb.pc file will break openobex.pc but you think it is better than not supporting libusb-without-pkgconfig at all. I was seeing the broken openobex.pc file as worse problem, and preferred just telling the user "get a newer libusb, otherwise your openobex install will be broken". I see it as a problem because I think pkg-config support is important for a library. It is just my personal view, anyway. >=20 > And as I said, make the upstream libusb maintainer to release a new > version that includes libusb.pc or tell the package maintainer to fix > their package. It seems the Ubuntu guys did, so no big deal. The problem I see is that I give more importance to have pkg-config support on openobex working. I see it as important enough that it is worth a workaround until a new libusb with pkg-config support is released. After all, openobex is a library and I suppose we want people to be able to use it easily on their buildsystems. Anway, I suggest the workaround below. It will affect only the pkg-config support on openobex (that is broken when using the upstream libusb, right now). Feel free to drop it if you still disagree with my point. I won't take it personally, I understood your point. :) But I just think that it is good to keep openobex pkgconfig working when using the upstream libusb. --=20 Eduardo diff -u -r1.7 openobex/acinclude.m4 --- openobex/acinclude.m4 3 Jan 2006 10:46:36 -0000 1.7 +++ openobex/acinclude.m4 19 Jan 2006 13:03:28 -0000 @@ -189,7 +189,6 @@ =20 if (test "${usb_enable}" =3D "yes" && test "${usb_found}" =3D "yes"); then AC_DEFINE(HAVE_USB, 1, [Define if system supports USB and it's enabled]) - REQUIRES=3D"$REQUIRES libusb" fi =20 AM_CONDITIONAL(APPS, test "${apps_enable}" =3D "yes") |